Repository navigation
feat(mcp): resolve room-scoped servers during owned Codex startup - #855
Closed
bandzalkin wants to merge 6 commits into
Closed
bandzalkin wants to merge 6 commits into
bandzalkin wants to merge 6 commits into
Conversation
This was referenced Oct 19, 2026
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 19, 2026
Source-Base: a96fb54 Source-Head: 89742de Upstream-PR: band-ai#855
bandzalkin
force-pushed
the
feat/codex-owned-mcp-resolver
branch
from
October 20, 2026 06:36
89742de to
cad1f8b
Compare
bandzalkin
requested review from
AlexanderZ-Band and
amit-gazal-band
as code owners
October 20, 2026 06:36
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 20, 2026
Source-Base: ecd2b1b Source-Head: cad1f8b Upstream-PR: band-ai#855
Port the reviewed cancellation correction from dd8f3af..942759f4. Delegate acquisition cancellation explicitly to the matching startup owner, preserve first abandonment/cleanup diagnostics, and cover public caller/cleanup orderings after uncancel. Keep Claude-owned retention changes in the stacked Claude PR.
bandzalkin
force-pushed
the
feat/codex-owned-mcp-resolver
branch
from
October 20, 2026 11:45
cad1f8b to
10178db
Compare
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 4949eba Source-Head: 10178db Upstream-PR: band-ai#855
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 4949eba Source-Head: 10178db Upstream-PR: band-ai#855
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 4949eba Source-Head: 10178db Upstream-PR: band-ai#855
Contributor
Author
|
Closing: band-agent does not consume this; may be re-proposed per feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex needs to acquire external MCP servers when a room connection starts, rather than reuse credentials and configuration captured before that room existed. MCP resolution, native startup, and teardown must have one owner so a cancelled or failed startup cannot leave a child process or credential-bearing resources behind.
What changes
Validation
Tests cover descriptor validation and redaction, launch precedence, resolver failure, concurrent startup, cancellation, reconnect, and process cleanup. I also verified protected bearer delivery with an actual Python child.