Skip to content

refactor: remove unused ErrorType enum (#670) - #719

Merged
Jamie-BitFlight merged 1 commit into
mainfrom
refactor/670-remove-unused-error-type
Oct 10, 2026
Merged

Jamie-BitFlight merged 1 commit into
mainfrom
refactor/670-remove-unused-error-type

Conversation

@Jamie-BitFlight

Copy link
Copy Markdown
Contributor

Removes src/errors/error-type.ts, which has no known production consumers and is not part of the published root declarations. Retains the active ConfigKeys and LogGroup enums; enum-to-object conversion is not justified. Draft pending a full reference scan and CI verification. Related #670.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: bitflight-devops/github-action-readme-generator/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 46a8b774-441e-4478-8621-1aa95692e74a

📥 Commits

Reviewing files that changed from the base of the PR and between edb05b4 and 5e9de5d.


📒 Files selected for processing (1)
  • src/errors/error-type.ts

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 92.65% 1009 / 1089
🔵 Statements 92.79% 1031 / 1111
🔵 Functions 95.62% 153 / 160
🔵 Branches 85.84% 552 / 643
File CoverageNo changed files found.
Generated in workflow #1067 for commit 5e9de5d by the Vitest Coverage Report Action

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 92.65% 1009 / 1089
🔵 Statements 92.79% 1031 / 1111
🔵 Functions 95.62% 153 / 160
🔵 Branches 85.84% 552 / 643
File CoverageNo changed files found.
Generated in workflow #1067 for commit 5e9de5d by the Vitest Coverage Report Action

@Jamie-BitFlight
Jamie-BitFlight marked this pull request as ready for review October 10, 2026 21:12
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T21:15:17.591840Z 5e9de5d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Jamie-BitFlight Jamie-BitFlight left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic review of PRs #717–#728

Reviewed 5e9de5dfb9efe539665563d0e9a8ac2af4919e9e against main at edb05b4eeea35e03df75b066b8ddd1d708de9f1c.

Assessment: necessary dead-code deletion; ready for final verification. No actionable defect found.

I checked source, tests, documentation, entry points, package exports, and tracked distribution declarations. ErrorType is referenced only by the deleted declaration; the supported package root exports generateReadme, and there is no supported subpath exposing this enum. No caller or meaningful test owner is left behind.

Deletion addresses the stale item in #670 more simply than replacing an unused enum with a new object. It does not imply that the actively used ConfigKeys or LogGroup enums should also change. A keyword-absence test would not establish any user-facing contract and is not recommended.

Current-head Node 24/26, lint and both real-repository integration checks are successful. This PR is independent of the error and logger stacks.

@Jamie-BitFlight
Jamie-BitFlight merged commit 2d9dcf8 into main Oct 10, 2026
11 checks passed
@Jamie-BitFlight
Jamie-BitFlight deleted the refactor/670-remove-unused-error-type branch October 10, 2026 23:11
@Jamie-BitFlight

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jamie-BitFlight Jamie-BitFlight added the released This issue/pull request has been released. label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant