Repository navigation
refactor: remove unused ErrorType enum (#670) - #719
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File CoverageNo changed files found. |
1 similar comment
Coverage Report
File CoverageNo changed files found. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Jamie-BitFlight
left a comment
There was a problem hiding this comment.
Holistic review of PRs #717–#728
Reviewed 5e9de5dfb9efe539665563d0e9a8ac2af4919e9e against main at edb05b4eeea35e03df75b066b8ddd1d708de9f1c.
Assessment: necessary dead-code deletion; ready for final verification. No actionable defect found.
I checked source, tests, documentation, entry points, package exports, and tracked distribution declarations. ErrorType is referenced only by the deleted declaration; the supported package root exports generateReadme, and there is no supported subpath exposing this enum. No caller or meaningful test owner is left behind.
Deletion addresses the stale item in #670 more simply than replacing an unused enum with a new object. It does not imply that the actively used ConfigKeys or LogGroup enums should also change. A keyword-absence test would not establish any user-facing contract and is not recommended.
Current-head Node 24/26, lint and both real-repository integration checks are successful. This PR is independent of the error and logger stacks.
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Removes
src/errors/error-type.ts, which has no known production consumers and is not part of the published root declarations. Retains the activeConfigKeysandLogGroupenums; enum-to-object conversion is not justified. Draft pending a full reference scan and CI verification. Related #670.