Repository navigation
fix: add CLI-only generation error boundary (#654) - #725
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Jamie-BitFlight
left a comment
Jamie-BitFlight
left a comment
There was a problem hiding this comment.
Holistic review of PRs #717–#728
Reviewed b856af2892d1cb90f5ea8f7c19a7c9d6a99944fb against main at edb05b4eeea35e03df75b066b8ddd1d708de9f1c.
Assessment: correction required — critical packaging defect (P1).
The dynamic-import boundary is a coherent way to catch import-time execution failures while leaving the library entry's existing execution contract unchanged; process.exitCode = 1 also preserves normal completion/stream flushing. However, the changed build entry emits dist/bin/cli.js, while the package and Action still require dist/bin/index.js. Exact-head unit-workflow and real-repository integration logs confirm the build failure described inline.
The 688 passing unit tests do not verify this new binary: those workflow tests run before the build and can execute the tracked released artifact. After correcting the filename, build first and test only the newly generated dist/bin/index.js in a directory without node_modules, including successful generation and nonzero failure reporting. The separate combined-source probe exercised this boundary and passed the README contract verifier, but its esbuild/available-dependency harness is not evidence that this Vite+ package builds.
Separate pre-existing finding from the batch review (P1; do not attribute it to this PR): native Node 24.19.0 cannot import main's exact tracked dist/mjs/index.js with locked nconf@0.13.0: import { Provider } from 'nconf' fails during module linking. The library artifact's Git blob was verified, and the installed nconf entry/manifest match upstream v0.13.0 byte for byte; native nconf exposes default.Provider, not a named Provider. Main's source import is unchanged here. Track a separate compatible CommonJS-interop correction and native built-library consumer smoke test; this finding does not justify changing the library's execution semantics in #725.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
## [2.0.5](v2.0.4...v2.0.5) (2026-10-11) ### Bug Fixes * add CLI-only generation error boundary ([#654](#654)) ([#725](#725)) ([6a27eaa](6a27eaa)) * **ci:** honor explicit Node versions before automatic detection ([95a9e68](95a9e68)) * **ci:** honor explicit Node versions in the test matrix ([#735](#735)) ([3f03f0d](3f03f0d)) * complete SVG writes before reporting success ([#717](#717)) ([170e499](170e499)) * consistently interpret GitHub Actions environment flag ([#670](#670)) ([#723](#723)) ([68756ad](68756ad)) * fail generation on formatting and requested save errors ([#654](#654)) ([#718](#718)) ([bb48434](bb48434)) * guard malformed runs metadata and preserve load error causes ([#720](#720)) ([c6caf7a](c6caf7a)) * load native ESM configuration and verify fresh package entry points ([5f92784](5f92784)) * load native ESM configuration and verify fresh package entry points ([#733](#733)) ([55746ed](55746ed)) * pair section log groups and honor Actions mode at output boundaries ([2d45100](2d45100)) * pair section log groups and honor Actions output mode ([#734](#734)) ([ceaa03a](ceaa03a)) * preserve empty metadata descriptions and cover reviewed errors ([3c0a181](3c0a181)) * preserve empty metadata descriptions and verify reviewed error paths ([#732](#732)) ([f8c0f4e](f8c0f4e)) * preserve original file read error as cause ([#722](#722)) ([05553e0](05553e0)) * validate consumed nested metadata descriptions ([#670](#670)) ([#729](#729)) ([330ab9a](330ab9a)) * validate README section configuration at input boundary ([#670](#670)) ([#726](#726)) ([40c9efd](40c9efd)) * verify declared defaults using their rendered projection ([beb2180](beb2180)) * verify empty metadata descriptions through the contract checker ([a5e2d31](a5e2d31))
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 participant
Use a separate CLI entry module to report a concise error and set a nonzero exit status, while leaving the published ESM library entry and its import-time rejection behaviour unchanged. The CLI build points at
src/cli.ts; the library still points atsrc/index.ts.Draft pending standalone bundled-binary integration verification, build output inspection, CI and regression tests. This changes the CLI bundle entry and should be merged after verification of packaging invariants. Related #654 and #670.