Repository navigation
fix: pair section log groups and honor Actions mode at output boundaries - #734
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Jamie-BitFlight
marked this pull request as ready for review
October 11, 2026 00:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Jamie-BitFlight
force-pushed
the
fix/review-followup-logger-20261011
branch
from
October 11, 2026 00:44
5ea581b to
ecf43b3
Compare
This was referenced Oct 11, 2026
Preserve absent, empty, null, and multiline default distinctions in the exact README verifier. Exercise real YAML generation under both formatting settings and require corrupted default projections to fail.
Access nconf through its native default export and preserve configuration precedence. Build before native CLI and library contract tests, retain active coverage output, and run the fresh package suite before external integrations. Capture the complete README when native import resolves so a pending write cannot pass the completion assertion by finishing during process shutdown.
Keep group ownership on the instance that opened it and close every synchronous section scope in finally. Prepare asynchronous usage descriptions before opening the rendering group, preserving concurrent preparation and repeated sections. Apply exact-true Actions detection to existing output boundaries, remove unused group-format state, and cover native SVG failure, completion, error identity, and real caller lifecycle behavior.
Jamie-BitFlight
force-pushed
the
fix/review-followup-logger-20261011
branch
from
October 11, 2026 01:20
ecf43b3 to
2d45100
Compare
Jamie-BitFlight
pushed a commit
that referenced
this pull request
Oct 11, 2026
## [2.0.5](v2.0.4...v2.0.5) (2026-10-11) ### Bug Fixes * add CLI-only generation error boundary ([#654](#654)) ([#725](#725)) ([6a27eaa](6a27eaa)) * **ci:** honor explicit Node versions before automatic detection ([95a9e68](95a9e68)) * **ci:** honor explicit Node versions in the test matrix ([#735](#735)) ([3f03f0d](3f03f0d)) * complete SVG writes before reporting success ([#717](#717)) ([170e499](170e499)) * consistently interpret GitHub Actions environment flag ([#670](#670)) ([#723](#723)) ([68756ad](68756ad)) * fail generation on formatting and requested save errors ([#654](#654)) ([#718](#718)) ([bb48434](bb48434)) * guard malformed runs metadata and preserve load error causes ([#720](#720)) ([c6caf7a](c6caf7a)) * load native ESM configuration and verify fresh package entry points ([5f92784](5f92784)) * load native ESM configuration and verify fresh package entry points ([#733](#733)) ([55746ed](55746ed)) * pair section log groups and honor Actions mode at output boundaries ([2d45100](2d45100)) * pair section log groups and honor Actions output mode ([#734](#734)) ([ceaa03a](ceaa03a)) * preserve empty metadata descriptions and cover reviewed errors ([3c0a181](3c0a181)) * preserve empty metadata descriptions and verify reviewed error paths ([#732](#732)) ([f8c0f4e](f8c0f4e)) * preserve original file read error as cause ([#722](#722)) ([05553e0](05553e0)) * validate consumed nested metadata descriptions ([#670](#670)) ([#729](#729)) ([330ab9a](330ab9a)) * validate README section configuration at input boundary ([#670](#670)) ([#726](#726)) ([40c9efd](40c9efd)) * verify declared defaults using their rendered projection ([beb2180](beb2180)) * verify empty metadata descriptions through the contract checker ([a5e2d31](a5e2d31))
Contributor
Author
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The #728 review found reached group-lifecycle errors: an unstarted helper could close a caller's group, a thrown section could leave a group open, and repeated usage updates could overlap GitHub Actions' global group stream. Runtime tracing also found that
GITHUB_ACTIONS=falsestill published four action outputs despite suppressing groups.Changes
finally, preserving the original error.Dependency and scope
Commit ancestry is #732 → #733 → this PR; the PR targets main for the existing integration trigger. Own commit 2d45100 changes 16 additional files. Other changes are inherited, including both independently checked verifier corrections and the package completion assertion.
An actual three-way merge reproduced the adjacent
Inputs.loadConfigconflict. This branch retains bothnconf.Providerand the corrected Actions predicate.Verification
The lifecycle regressions fail on 11 main behaviors; the output regression fails specifically in false mode. Corrected focused suites, native CLI cases and actual
GITHUB_OUTPUTcaptures pass. A fresh independent re-review traced all production group openers and found no additional actionable defect. Restoring unconditional cleanup, parent usage ordering, missing synchronous cleanup or truthy output guards fails the intended behavioral assertions.The complete combined snapshot passed canonical format/lint/type checks and JSON-reported coverage: 722 tests in 25 files, zero failed or skipped, including a fresh build and native packaged-entry tests.
At head
2d451006f5de39e2b9c370647e172e460c2590a4, unit/coverage CI passed 722 tests in 25 files in each named lane, plus checks, build and docs. Both external integrations passed the fresh package suite, exact README contract and convergence. Lint and both CodeQL analyses passed.Both lanes actually ran Node 24.19.0. The shared setup action ignores the requested 26.x version after project detection succeeds. CI correction #735 now establishes execution of this complete application snapshot on actual Node 24.19.0 and Node 26.11.1. Both lanes pass 722 tests and coverage, checks, build and docs in run 38102235836; #735's only additional change is the setup action.
No generated bundles are committed. Independent runtime review and observed execution establish this assessment; job labels or unfinished bot reviews are not counted as completed verification. Follow-up to #717, #723 and closed #728.