Repository navigation
fix(ci): honor explicit Node versions in the test matrix - #735
Merged
Merged
Conversation
Preserve absent, empty, null, and multiline default distinctions in the exact README verifier. Exercise real YAML generation under both formatting settings and require corrupted default projections to fail.
Access nconf through its native default export and preserve configuration precedence. Build before native CLI and library contract tests, retain active coverage output, and run the fresh package suite before external integrations. Capture the complete README when native import resolves so a pending write cannot pass the completion assertion by finishing during process shutdown.
Keep group ownership on the instance that opened it and close every synchronous section scope in finally. Prepare asynchronous usage descriptions before opening the rendering group, preserving concurrent preparation and repeated sections. Apply exact-true Actions detection to existing output boundaries, remove unused group-format state, and cover native SVG failure, completion, error identity, and real caller lifecycle behavior.
Give the matrix's requested version precedence over installed or project-detected versions. Preserve automatic selection and the existing fallback for callers that omit the input, and pass explicit input through the step environment.
Jamie-BitFlight
marked this pull request as ready for review
October 11, 2026 01:33
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Jamie-BitFlight
commented
Oct 11, 2026
Jamie-BitFlight
left a comment
Jamie-BitFlight
left a comment
Contributor
Author
There was a problem hiding this comment.
Runtime review identified the existing setup-action coverage gap that this PR corrects. The inline record distinguishes the reproduced selector defect, independently checked correction, and hosted execution evidence still being gathered.
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Jamie-BitFlight
pushed a commit
that referenced
this pull request
Oct 11, 2026
## [2.0.5](v2.0.4...v2.0.5) (2026-10-11) ### Bug Fixes * add CLI-only generation error boundary ([#654](#654)) ([#725](#725)) ([6a27eaa](6a27eaa)) * **ci:** honor explicit Node versions before automatic detection ([95a9e68](95a9e68)) * **ci:** honor explicit Node versions in the test matrix ([#735](#735)) ([3f03f0d](3f03f0d)) * complete SVG writes before reporting success ([#717](#717)) ([170e499](170e499)) * consistently interpret GitHub Actions environment flag ([#670](#670)) ([#723](#723)) ([68756ad](68756ad)) * fail generation on formatting and requested save errors ([#654](#654)) ([#718](#718)) ([bb48434](bb48434)) * guard malformed runs metadata and preserve load error causes ([#720](#720)) ([c6caf7a](c6caf7a)) * load native ESM configuration and verify fresh package entry points ([5f92784](5f92784)) * load native ESM configuration and verify fresh package entry points ([#733](#733)) ([55746ed](55746ed)) * pair section log groups and honor Actions mode at output boundaries ([2d45100](2d45100)) * pair section log groups and honor Actions output mode ([#734](#734)) ([ceaa03a](ceaa03a)) * preserve empty metadata descriptions and cover reviewed errors ([3c0a181](3c0a181)) * preserve empty metadata descriptions and verify reviewed error paths ([#732](#732)) ([f8c0f4e](f8c0f4e)) * preserve original file read error as cause ([#722](#722)) ([05553e0](05553e0)) * validate consumed nested metadata descriptions ([#670](#670)) ([#729](#729)) ([330ab9a](330ab9a)) * validate README section configuration at input boundary ([#670](#670)) ([#726](#726)) ([40c9efd](40c9efd)) * verify declared defaults using their rendered projection ([beb2180](beb2180)) * verify empty metadata descriptions through the contract checker ([a5e2d31](a5e2d31))
Contributor
Author
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Direct review of the CI logs for #732–#734 found that both named matrix lanes actually ran Node 24.19.0. In the lane requesting 26.x, the local setup action chose the project pin before consulting its explicit input. This silently omitted Node 26 coverage while the job remained green.
Example: #732's nominal Node 26 job records requested
26.x, selected24.19.0, and actualnode: v24.19.0. The same sequence appears in #733 and #734. Earlier job-label-based Node 26 claims have been corrected in those PR descriptions.Changes
24.xfallback for omitted inputs.NODE_VERSION, andactions/setup-node.Own commit 95a9e68 changes only
.github/actions/setup-node/action.yml.Dependency and scope
This PR is stacked on #734, after #732 and #733, to verify the complete reviewed application on the requested runtimes. The PR targets main so the existing integrations run. Other files in the full PR diff are inherited.
The existing
pull_request_targettest definition checks out the PR branch and loads its local setup action, so this action-file correction can be verified before merge without changing the workflow definition.Verification
The author and a fresh independent checker separately parsed the actual YAML and executed its extracted Bash with controlled installed/project versions. Baseline explicit 26.x requests select 24.19.0; the correction passes 26.x to setup-node. Explicit pinned versions and setup-node selectors are also preserved. Omitted/empty inputs keep the same detection output, command sequence and fallback warning. All active workflow callers remain unchanged.
The independent checker marked the finding satisfied. YAML parsing, Bash syntax and whitespace checks passed. Hosted execution is now verified at
95a9e6808c2b0ee77369f3ea54193ec2e07c64a7:This run verifies the complete inherited application stack on the two actual runtimes. Earlier #732–#734 logs remain recorded as Node 24.19.0 execution.
Merge order: #732 → #733 → #734 → this PR. No application, dependency, version-resolution policy, or generated-distribution change is introduced by this commit.