test: convert tui-pty terminal-safety comment-out skip to it.skip.each - #187
vashbrightfire[bot] wants to merge 1 commit into
Conversation
![vashbrightfire[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
The commented-out import/case orphans exerciseTerminalOutputSafety for knip's all-exports scan (raw-tree PR CI failure on this branch, same root cause fixed on brightfire/ci in #181). it.skip.each keeps the case listed and the export referenced. No behavior change.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3400ae175
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| it.skip.each([ | ||
| "sanitizes ANSI OSC and C1 payloads across real PTY display boundaries", | ||
| () => exerciseTerminalOutputSafety(startTuiFixture, STARTUP_TIMEOUT_MS), | ||
| ])("%s", async (_name, runCase) => runCase(), STARTUP_TEST_TIMEOUT_MS); |
There was a problem hiding this comment.
Vitest treats each top-level array element as a separate row, so this flat [title, fn] table registers two skipped tests instead of the intended single two-argument case. Besides making the skipped-test inventory inaccurate, removing .skip after the CI flake is fixed would invoke both rows without a callable runCase and fail before exercising terminal safety; wrap the pair in an outer array.
Useful? React with 👍 / 👎.
1 participant
Mirrors the fix already merged to brightfire/ci in #181: the comment-out skip orphans
exerciseTerminalOutputSafetyfor knip's all-exports scan, failing raw-tree PR CI on this patch branch.it.skip.eachkeeps the case listed and the export referenced. No behavior change — the case stays skipped for the same CI-flakiness reason.