Skip to content

test: convert tui-pty terminal-safety comment-out skip to it.skip.each #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vashbrightfire wants to merge 1 commit into from
Closed

test: convert tui-pty terminal-safety comment-out skip to it.skip.each #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/tui/tui-pty-harness.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
disposeActiveTuiFixtures,
exerciseFragmentedUnicodePrompt,
exerciseNarrowTerminalRendering,
// exerciseTerminalOutputSafety, // Disabled: test case commented out for CI flakiness
exerciseTerminalOutputSafety,
objectFieldEquals,
readFixtureLog,
startTuiFixture,
Expand Down Expand Up @@ -728,10 +728,17 @@ describe.sequential("TUI PTY harness", () => {
// prettier-ignore
const terminalSafetyCases = [
["renders long Unicode output and copy-safe URLs in narrow real PTY frames", () => exerciseNarrowTerminalRendering(startTuiFixture, STARTUP_TIMEOUT_MS)],
// ["sanitizes ANSI OSC and C1 payloads across real PTY display boundaries", () => exerciseTerminalOutputSafety(startTuiFixture, STARTUP_TIMEOUT_MS)],
] as const;
it.each(terminalSafetyCases)("%s", async (_name, runCase) => runCase(), STARTUP_TEST_TIMEOUT_MS);

// Skipped (same CI flakiness as above) via it.skip.each so the case stays
// listed and the exerciseTerminalOutputSafety import stays live for knip's
// unused-export scan.
it.skip.each([
"sanitizes ANSI OSC and C1 payloads across real PTY display boundaries",
() => exerciseTerminalOutputSafety(startTuiFixture, STARTUP_TIMEOUT_MS),
])("%s", async (_name, runCase) => runCase(), STARTUP_TEST_TIMEOUT_MS);
Comment on lines +737 to +740

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Nest the skipped case as an each-table row

Vitest treats each top-level array element as a separate row, so this flat [title, fn] table registers two skipped tests instead of the intended single two-argument case. Besides making the skipped-test inventory inaccurate, removing .skip after the CI flake is fixed would invoke both rows without a callable runCase and fail before exercising terminal safety; wrap the pair in an outer array.

Useful? React with 👍 / 👎.


// Disabled: flaky in CI — times out waiting for "monthly spending limit" under CPU contention.
it.skip(
"preserves xAI account limit errors in terminal output",
Expand Down
Loading