Skip to content

fix(generator): resolve generated value model runtime types - #233

Merged
leoafarias merged 2 commits into
fix/2.0-generator-schema-metadatafrom
fix/2.0-generator-runtime-types
Oct 27, 2026
Merged

leoafarias merged 2 commits into
fix/2.0-generator-schema-metadatafrom
fix/2.0-generator-runtime-types

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Models referenced in the same generation run were assumed to contain JSON maps. Scalar, list, and codec-backed models could therefore generate invalid casts.

  • Infer each referenced model's actual runtime type.
  • Fix codec type arguments for nullable Set values inside maps.

Validation

  • Regression tests passed for scalar/list/codec references and nullable nested Sets.
  • Generated fixtures build, analyze, round-trip, and regenerate consistently; runtime tests also cover PATCH values, immutability, and conversion call counts.

@leoafarias
leoafarias marked this pull request as ready for review October 26, 2026 16:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-27T00:00:50.967404Z 3e12fbb New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leoafarias
leoafarias added this pull request to stack #238 October 26, 2026 16:30
@leoafarias
leoafarias merged commit 2bf9c86 into release/2.0 Oct 27, 2026
7 of 14 checks passed
@leoafarias
leoafarias deleted the fix/2.0-generator-runtime-types branch October 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant