Skip to content

fix(generator): validate generated names and getter references - #234

Merged
leoafarias merged 2 commits into
fix/2.0-generator-runtime-typesfrom
fix/2.0-generator-name-contracts
Oct 27, 2026
Merged

leoafarias merged 2 commits into
fix/2.0-generator-runtime-typesfrom
fix/2.0-generator-name-contracts

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Name collisions could produce Dart code that does not compile. Models declared with annotated getters were also missed when referenced in the same build.

  • Detect conflicting generated names and duplicate schema keys before emitting code.
  • Resolve annotated getter models alongside models declared as variables.

Validation

  • Nine diagnostic and getter regressions passed.
  • Clean generation, analysis, runtime round trips, and repeat-build checks passed.

@leoafarias
leoafarias marked this pull request as ready for review October 26, 2026 16:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T00:02:02.283618Z c818de2 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leoafarias
leoafarias added this pull request to stack #238 October 26, 2026 16:30
@leoafarias
leoafarias merged commit 07b5ba4 into release/2.0 Oct 27, 2026
7 checks passed
@leoafarias
leoafarias deleted the fix/2.0-generator-name-contracts branch October 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant