Skip to content

fix: preserve null overrides and simplify Dart ownership - #241

Open
leoafarias wants to merge 2 commits into
fix/2.0-bundled-dialect-discoveryfrom
refactor/2.0-dart-ownership
Open

leoafarias wants to merge 2 commits into
fix/2.0-bundled-dialect-discoveryfrom
refactor/2.0-dart-ownership

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Remove unnecessary indirection while preserving the 2.0 contracts.

  • Delete two single-owner utility files, use direct primitive constructors, and consolidate metadata/property handling.
  • Fix generation rejecting parenthesized null no-op overrides; correct the provider-response example and docs version metadata.
  • Keep full analyzer bound substitution at its call site because analyzer 13 has no equivalent public operation.

Stacked on #239. No public API, dependency, or SDK-floor changes.

Validation

  • Parenthesized-null regressions, full-workspace tests, browser coverage and documentation checks passed.
  • Both minimum SDKs, API compatibility, clean regeneration and all five zero-warning publish dry runs passed.
  • CI and release preflight passed on 43c4186. Documentation also passed.

Four live Firebase tests remain skipped. #240 was merged separately into the release base; this PR remains unmerged. No tag or package publication is part of this work.

@leoafarias
leoafarias added this pull request to stack #238 October 26, 2026 23:01
@leoafarias
leoafarias marked this pull request as ready for review October 26, 2026 23:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T00:02:01.255325Z 43c4186 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant