Repository navigation
chore(remix): require mix 2.3.1 - #313
Merged
Merged
Conversation
Raise the mix floor to ^2.3.1 for its Prop fallback fix (the latest source wins when a value cannot be converted) and keep the toolchain floor notes in step.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raises Remix's
mixfloor from^2.3.0to^2.3.1inpackages/remix,registry_sourceand the root melos shared dependencies, and updates the lockfile.Mix 2.3.1 (btwld/mix#1096, #1104) fixes
Propresolution: when a value can't be converted to aMix, the latest source now wins instead of an earlierMix. Debug builds report the missing converter throughFlutterError.reportError.The toolchain floor stays at Flutter 3.44 / Dart 3.12. Only the notes naming the Mix version change (
tool/check_toolchain.dart, the remix pubspec comment,docs/getting-started.mdx).Related Issues
btwld/mix#1096
Checklist
My PR includes unit or integration tests for all changed/updated/fixed behaviors. The behavior change is tested in Mix. Remix suites pass against hosted mix 2.3.1:
remixregistry_sourcemelos run ci:checks(includes the hosted-Mix consumer check),docs:checkandgenerate:checkI have updated or added relevant documentation (doc comments with
///).I am prepared to follow up on review comments in a timely manner.
Breaking Change