Start Clementine without the remote streaming flag - #294
Merged
Merged
Conversation
Clementine plays on remotes by default since 1.4.1-238, and refuses --experimental-remote-streaming. CI always tests against its latest release, so the test image no longer looks for the flag, and the README no longer mentions it. STREAMING=1 still turns on "Allow playing on remote devices". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012foWs5vBJrYTDtfyFhJ3ky
Store screenshotsFrom run 36704894238, against clementine-it. Left: the store listing on master. Right: this pull request, light and dark.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clementine plays on remotes by default since 1.4.1-238. Its latest release, 1.4.1-243, no longer has
--experimental-remote-streaming: the flag doesn't appear anywhere in its binary.The integration and store-screenshot workflows always download Clementine's latest release, so neither needs a pinned version bumped. What this changes:
clementine-it/entrypoint.shjust starts Clementine, no longer checking whether the binary knows the flag.clementine-it/README.mdno longer mentions the flag.STREAMING=1still turns on Allow playing on remote devices: 1.4.1-243 still has the setting, andRemoteStreamingIntegrationTestis skipped without it.This PR's
integrationand screenshot checks run against 1.4.1-243. I couldn't run them locally, because this environment has no Docker daemon.The iOS client has the same change in clementine-player/iOS-Remote#18.
🤖 Generated with Claude Code
https://claude.ai/code/session_012foWs5vBJrYTDtfyFhJ3ky
Generated by Claude Code