Skip to content

Start Clementine without the remote streaming flag #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatstand merged 1 commit into from
Sep 30, 2026
Merged

Start Clementine without the remote streaming flag #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clementine-it/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ docker run --rm -d --name clementine -p 5500:5500 -e AUTH_CODE=12345 -e STREAMIN
-Pclementine.host=localhost -Pclementine.authCode=12345
```

`STREAMING=1` starts Clementine with remote streaming (*Allow playing on remote devices*, and `--experimental-remote-streaming` for releases before 1.4.1-238, which need it), so it can play on the app's renderer; without it, `RemoteStreamingIntegrationTest` is skipped.
`STREAMING=1` starts Clementine with remote streaming (*Allow playing on remote devices*), so it can play on the app's renderer; without it, `RemoteStreamingIntegrationTest` is skipped.

CI uses Clementine's latest release by default. You can choose a different release tag when starting the workflow by hand.

Expand Down
8 changes: 1 addition & 7 deletions clementine-it/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,7 @@ if [ "${1:-}" = "--seed" ]; then
exit 0
fi

# Releases before 1.4.1-238 play on remotes only with --experimental-remote-streaming; later ones
# do by default and refuse the flag. The binary names its long options without the dashes.
streaming=()
if [ "${STREAMING:-}" = 1 ] && grep -q -a experimental-remote-streaming "$(command -v clementine)"; then
streaming=(--experimental-remote-streaming)
fi
dbus-run-session -- clementine --verbose "${streaming[@]}" &
dbus-run-session -- clementine --verbose &
pid=$!
trap 'kill $pid 2>/dev/null' TERM INT

Expand Down
Loading