feat(registry) #33 Give the service ids in the error on duplicate client codes - #34
Merged
Merged
Conversation
…ent codes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks done
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33.
Two clients with the same code made every REST process fail with
Client <code> is already defined, without telling which services are in conflict (they usually share the same class).RegisterClientsPass(new): registers the services taggedcleverage.rest.clientinClientRegistrywith their service id, replaces the genericRegistryCompilerPassClientRegistry::addClient(): new optional$serviceIdargument; on a duplicate code, the message gives the ids of both services (unchanged message when an id is missing)ClientRegistryTest,RegisterClientsPassTest(new)reference/client.md: update the note on unique codesChecked with process-bundle-demo, with a second
app.cleverage_rest_process.client.apicarto_ign_duplicateclient service with theapicarto_igncode:demo.rest.getnow fails withClient apicarto_ign is already defined by service "app.cleverage_rest_process.client.apicarto_ign", cannot register service "app.cleverage_rest_process.client.apicarto_ign_duplicate"; without the duplicate, it still runs successfully.Same change in cleverage/cache-process-bundle#26 and cleverage/soap-process-bundle#27 (see the related issues).
Requirements
Breaking changes
None: the new argument of
ClientRegistry::addClient()is optional, only the exception message changes.🤖 Generated with Claude Code