Skip to content

[vite-plugin] Backport October 19 SDK release to v1 - #16355

Open
petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16352from
codex/vite-v1-backport-16313
Open

petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16352from
codex/vite-v1-backport-16313

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Backport the compatible SDK release from #16313 to Vite plugin v1, stacked on #16354 (the separate original #16352 runtime backport) above #16334 and #16333. The stack ultimately targets vite-plugin-v1.

Miniflare 5.20261019.0-beta is compatible with v1 and is supplied consistently by #16333 in the plugin, private remote-bindings, and the retained account-id install consumer. That earliest necessary backport also supplies coupled Wrangler 4.151.2, runtime-types 0.1.13, workerd 1.20261019.1, and Workers types 5.20261019.1; #16334 supplies containers-shared 0.23.0 and deploy-helpers 0.22.0. All are published, and both preceding lockfiles are regenerated. No dependency bump is repeated or reverted here.

Preserve a separate one-to-one release backport with its own plugin patch changeset and real dev/preview tests importing the built v1 plugin. The tests verify that Wrangler configuration parsing, Miniflare startup, Worker bindings, requests, and generated preview output work together at the release's compatibility date. V2 version/changelog metadata is not transplanted into v1; the v1 changeset workflow generates its own release metadata. Private support packages and workspace references remain intact, and absent public source is not restored.

Validation on Node.js 22.22.1 / pnpm 10.33.0: both built-plugin dev/preview smoke tests pass against the actual released SDK, together with the separate October 19 runtime regression and the runtime asset/type-generation tests. Build, all 8 retained unit tasks (281 plugin tests), frozen installation, and all 60 repository checks pass. Cross-platform CI and maintainer review remain required.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this maintains existing v1 behavior with compatible released SDK dependencies.

Note

This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.

@petebacondarwin petebacondarwin added dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package labels Oct 19, 2026
@changeset-bot

changeset-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1ce03bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team October 19, 2026 10:57
@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@workers-devprod (recorded release automation author of #16313, account name ANT Bot) and @petebacondarwin (verified human ant-core approver), could you please check this vite-plugin-v1 backport and approve it if it looks good?

This release keeps its own plugin changeset and real built-plugin dev/preview regression tests. Earlier backport #16333 supplies Miniflare 5.20261019.0-beta and its coupled Wrangler, workerd, Workers types, and runtime-types versions; #16334 supplies the Container/deployment helper versions. The dependencies are published and lockfiles regenerated, with build, all unit tests, and repository checks passing locally. Cross-platform CI is running. No v2 release metadata or absent public source is restored.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@clanky-the-clanker

Copy link
Copy Markdown

✅ Approved — No issues found. The pull request adds a patch changeset for @​cloudflare/vite-plugin and a dev/preview smoke test against the built v1 plugin, and both follow the repository's conventions.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

I found no issues in sdk-release.spec.ts or the changeset.

  • Dist import: the test imports the built plugin from ../../dist/index.mjs. This works because turbo.json makes the build task a dependency of the test and type-check tasks.
  • Test setup: the test follows the repository's testing rules. It uses runInTempDir, test-context expect and real temporary files, and cleans up through onTestFinished, including unstubbing the PWD env var.
  • Dev and preview paths: both paths check the full request round trip: Wrangler config parsing, the vars binding and the request URL handling.
  • Changeset: the changeset is patch-level for @cloudflare/vite-plugin, as the repository's rules require for user-facing changes.

📝 Documentation: ✅ LGTM

The changeset text describes the release alignment clearly. No public documentation change is needed for a dependency-compatibility backport.


Reviewed commit: 1ce03bcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants