Skip to content

[vite-plugin] Backport October 16 runtime updates to v1 - #16333

Open
petebacondarwin wants to merge 2 commits into
vite-plugin-v1from
codex/vite-v1-backport-16307
Open

petebacondarwin wants to merge 2 commits into
vite-plugin-v1from
codex/vite-v1-backport-16307

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Backport #16307 to Vite plugin v1, based directly on vite-plugin-v1. #16334, #16354 (original #16352), and #16355 (release #16313) stack above this PR.

Carry the original nested encoded-asset regression and runtime-type generation/cache coverage, with its own plugin patch changeset. The October 16 changes shipped together with the October 19 update in release #16313: Miniflare 5.20261016.0-beta was never published. Use the actual released Miniflare 5.20261019.0-beta, Wrangler 4.151.2, runtime-types 0.1.13, workerd 1.20261019.1, and Workers types 5.20261019.1. Wrangler and runtime-types require that exact Miniflare/workerd pair, so keep the coupled upgrades together here. Separate follow-ups retain their original-to-backport mapping, tests, and release notes without repeating these pins.

Pin Miniflare consistently in the plugin, private remote-bindings, and the retained account-id install fixture; update the Workers types catalog for retained private consumers. Preserve all private packages and workspace references. Public sibling source remains absent.

Validation on Node.js 22.22.1 / pnpm 10.33.0: full installation and generated lockfile, pnpm build (3 tasks), pnpm test:ci (8 tasks, 275 plugin tests), and pnpm check (60 tasks) pass against the actual released dependencies. Publication blockers are resolved. Cross-platform CI and maintainer review remain required.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this maintains existing v1 behavior with compatible released SDK dependencies.

Note

This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.

@petebacondarwin petebacondarwin added blocked Blocked on other work dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package labels Oct 17, 2026
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a3542b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@dependabot[bot] (recorded bot author of #16307) and @edmundhung (verified human ant-core approver), could you please check this vite-plugin-v1 backport and approve it when it is ready and looks good?

The v1 adaptation consumes the public runtime packages instead of restoring their source, pins Miniflare in retained private consumers, and adds the encoded-asset regression plus runtime-type coverage. The draft awaits the Miniflare, Wrangler, and runtime-types publication listed in the description; final lockfile/build/type/test validation must follow. This PR supplies its own dependency versions and remains separate from the Container guidance follow-up #16334.

Base automatically changed from codex/vite-v1-backport-16287 to vite-plugin-v1 October 17, 2026 14:50
@petebacondarwin
petebacondarwin force-pushed the codex/vite-v1-backport-16307 branch from 64a6688 to 530e2f0 Compare October 18, 2026 12:57
@petebacondarwin
petebacondarwin added this pull request to stack #16347 October 18, 2026 14:03
@petebacondarwin petebacondarwin removed the blocked Blocked on other work label Oct 19, 2026
@petebacondarwin
petebacondarwin marked this pull request as ready for review October 19, 2026 10:56
@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16333

commit: a3542b9

@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review


Update the local Workers runtime to include the October 16 fixes

Use the matching Miniflare, workerd, Wrangler, and runtime type generator releases. The combined October 19 release includes these fixes for nested asset paths on Windows; its runtime and types also supply the later runtime backport.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changeset obscures the user-facing fix

For users reading the changelog, Use the matching Miniflare describes release coordination instead of the local-development benefit. The changeset rule requires user-facing impact rather than maintainer implementation details.

Suggested change
Use the matching Miniflare, workerd, Wrangler, and runtime type generator releases. The combined October 19 release includes these fixes for nested asset paths on Windows; its runtime and types also supply the later runtime backport.
Nested assets with encoded filenames now load correctly during local development on Windows. Runtime types also reflect the updated Workers runtime.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@clanky-the-clanker

Copy link
Copy Markdown

✅ Approved — No issues found. The coupled Miniflare, Wrangler, workerd and types pins are consistent across the plugin, remote-bindings, the fixture and the catalog, and the regression test and changeset are included.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Risk: Low. The pinned versions match the released Miniflare/workerd pair that Wrangler 4.151.2 requires.


🔒 Security: ✅ LGTM

No security concerns in these dependency bumps or test additions.


📖 AGENTS.md: ✅ LGTM

The change follows the repository's guidance: public SDK packages use exact versions, private workspace references are kept, and a plugin changeset is included.


📋 Code Quality: ✅ LGTM

I found nothing to flag in the changed files.

  • Miniflare pin: miniflare is pinned to exactly 5.20261019.0-beta in the plugin, in remote-bindings and in the account-id fixture.
  • Plugin dependencies: wrangler is 4.151.2, with the peer range set to ^4.151.2. workerd is 1.20261019.1 and runtime-types is 0.1.13. workers-types is 5.20261019.1 in both the plugin and the catalog. Private dependencies stay as workspace:*.
  • Tests: The new runtime-assets.spec.ts regression test uses a real temporary directory, cleans up after itself, and uses test-context expect and node: imports. The compatibility date bump in runtime-types.spec.ts matches the new runtime.
  • Changeset: A plugin patch changeset is included.

⚡ Performance: ✅ LGTM

No performance concerns.


📝 Documentation: ✅ LGTM

The changeset is present. No other documentation changes are needed for this backport.


Reviewed commit: a3542b9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants