Repository navigation
[vite-plugin] Backport October 16 runtime updates to v1 - #16333
petebacondarwin wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: a3542b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dependabot[bot] (recorded bot author of #16307) and @edmundhung (verified human ant-core approver), could you please check this The v1 adaptation consumes the public runtime packages instead of restoring their source, pins Miniflare in retained private consumers, and adds the encoded-asset regression plus runtime-type coverage. The draft awaits the Miniflare, Wrangler, and runtime-types publication listed in the description; final lockfile/build/type/test validation must follow. This PR supplies its own dependency versions and remains separate from the Container guidance follow-up #16334. |
64a6688 to
530e2f0
Compare
commit: |
|
Codeowners approval required for this PR:
|
|
|
||
| Update the local Workers runtime to include the October 16 fixes | ||
|
|
||
| Use the matching Miniflare, workerd, Wrangler, and runtime type generator releases. The combined October 19 release includes these fixes for nested asset paths on Windows; its runtime and types also supply the later runtime backport. |
There was a problem hiding this comment.
🟡 Changeset obscures the user-facing fix
For users reading the changelog, Use the matching Miniflare describes release coordination instead of the local-development benefit. The changeset rule requires user-facing impact rather than maintainer implementation details.
| Use the matching Miniflare, workerd, Wrangler, and runtime type generator releases. The combined October 19 release includes these fixes for nested asset paths on Windows; its runtime and types also supply the later runtime backport. | |
| Nested assets with encoded filenames now load correctly during local development on Windows. Runtime types also reflect the updated Workers runtime. |
Was this helpful? React with 👍 or 👎 to provide feedback.
|
✅ Approved — No issues found. The coupled Miniflare, Wrangler, workerd and types pins are consistent across the plugin, remote-bindings, the fixture and the catalog, and the regression test and changeset are included. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🚀 Release: ✅ LGTMRisk: Low. The pinned versions match the released Miniflare/workerd pair that Wrangler 🔒 Security: ✅ LGTMNo security concerns in these dependency bumps or test additions. 📖 AGENTS.md: ✅ LGTMThe change follows the repository's guidance: public SDK packages use exact versions, private workspace references are kept, and a plugin changeset is included. 📋 Code Quality: ✅ LGTMI found nothing to flag in the changed files.
⚡ Performance: ✅ LGTMNo performance concerns. 📝 Documentation: ✅ LGTMThe changeset is present. No other documentation changes are needed for this backport. Reviewed commit: |
Backport #16307 to Vite plugin v1, based directly on
vite-plugin-v1. #16334, #16354 (original #16352), and #16355 (release #16313) stack above this PR.Carry the original nested encoded-asset regression and runtime-type generation/cache coverage, with its own plugin patch changeset. The October 16 changes shipped together with the October 19 update in release #16313: Miniflare
5.20261016.0-betawas never published. Use the actual released Miniflare5.20261019.0-beta, Wrangler4.151.2, runtime-types0.1.13, workerd1.20261019.1, and Workers types5.20261019.1. Wrangler and runtime-types require that exact Miniflare/workerd pair, so keep the coupled upgrades together here. Separate follow-ups retain their original-to-backport mapping, tests, and release notes without repeating these pins.Pin Miniflare consistently in the plugin, private remote-bindings, and the retained account-id install fixture; update the Workers types catalog for retained private consumers. Preserve all private packages and workspace references. Public sibling source remains absent.
Validation on Node.js 22.22.1 / pnpm 10.33.0: full installation and generated lockfile,
pnpm build(3 tasks),pnpm test:ci(8 tasks, 275 plugin tests), andpnpm check(60 tasks) pass against the actual released dependencies. Publication blockers are resolved. Cross-platform CI and maintainer review remain required.Note
This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.