Repository navigation
fix(appupdates): skip the server minimum-version gate in debug builds - #1829
Merged
Merged
Conversation
Debug builds ship versionCode 1, so any server minimumVersion put them behind UpdateRequiredBlockingView, where Play Core fails with InstallException -9 and the check retries forever. CI's debug APK never reached wallet_screen. GooglePlayAppUpdateController now takes ignoreServerMinimum, set from BuildConfig.DEBUG in AppUpdateModule. A staff override still shows the gate, and the debug optional-update harness is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debug builds ship
versionCode1, so any serverminimumVersionputs them behindUpdateRequiredBlockingView. In the nightly Maestro run 39898678397 the logcat shows:followed by a Play Core
InstallException -9(no Play-installed app on the emulator), while the blocking view keeps retrying. 12 of 13 smoke flows then fail onid: wallet_screen is visible/id: chat_screen is visible.GooglePlayAppUpdateControllergains anignoreServerMinimumparameter, whichAppUpdateModulesets fromBuildConfig.DEBUG. When set,checkForUpdate()returns early unless the minimum version has a staff override, so the override visualization still works in debug. Release builds are unchanged, and thedebug-optional-updatemarker andFakeAppUpdateManagerpath are untouched.ForcedUpdateTestgains two cases: the server minimum is ignored, and a staff override still shows the gate.Related to the nightly Maestro run fix in #1824.