Repository navigation
feat(onboarding): new-user onboarding tweaks - #1862
Merged
Merged
Conversation
A new account finishing onboarding now opens on Chats, where a cold launch and a sign-in already open, instead of Wallet (node 12527:81350). The permissions phase releases to launchRoute in every case. AppRoute.OnboardingFlow.newAccount existed only to pick Wallet for that release, so it goes. homeRoute stays Wallet as the base for launch deeplinks. OnboardingFlowScreenTest renders the permissions phase and asserts the stack ends as [Tabs.Chats]; it fails if the landing reverts to homeRoute. The create_account Maestro subflow now waits for chats_screen.
Frame 11 (node 12527:81782) drops the new-user tutorial card from the wallet. The "Send Your First Tip" checklist and its "Scan a Profile Card" item are gone; the Add Money row stays and hides once money has been added, the same signal that brings in the wallet tiles. Tipping no longer feeds the wallet, so WalletViewModel drops its ChatCoordinator dependency and the balance module drops shared:chat.
Frame 12 (node 12527:81838) drops "Claim your username" from the You tab and makes the primary button carry the nudge. Username stays settable from Edit Profile. The button reads "Complete Your Profile" in the dynamic accent the currency creator uses until the profile has a photo, a cover and a bio (isProfileComplete), then "Edit Profile" in the usual gray. Favorite chats are not required. The favorite community chats section now draws a "None yet" body when empty, but only once a read for the current username has succeeded, so an account with favorites does not flash it. The username progress card, its balance gate and ClaimUsername event leave MenuScreenViewModel with the link.
Frame 13 (node 12527:81886) replaces the "Claim your username" prompt with a Username row showing the current @handle, and rewords the photo actions to "Add cover photo" and "Add profile photo" on this screen only; group editing keeps its labels. Tapping Username while the handle is not one the user chose and the balance is under the minimum shows "$100 Balance Required" with Add Money and Dismiss. The amount is the existing usernameMinBalance user flag, formatted for the viewer, not a constant. Otherwise the tap opens the username step as before. isUsernameBalanceRequired holds the rule and is unit-tested.
github-actions
Bot
added
type: feature
… tab Frame 12 has no rule above the section, and iOS already removed it. The divider stays on other people's profiles, where FeaturedGroupsSection is also used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New users now land on Chats after onboarding, see only the Add Money row on Money, get a "Complete Your Profile" prompt on You, and set a username from a plain row on Edit Profile. Design: "(Ted) Tweak Screens For New User [Oct 22]", node 12527:81344, frames 10–13. iOS ships the same change in code-payments/code-ios-app#1139.
One commit per change:
launchRoute([Tabs.Chats],OnboardingFlowScreen.kt:156), the route sign-in and cold launch already use.AppRoute.OnboardingFlow.newAccountis deleted.homeRoute(Wallet) stays only as the deeplink base.ActivityFeedCoordinator.resolveHasReceivedMoneynow waits until the received-money read is known.ResolveHasReceivedMoneyTestcovers it.rememberDynamicAccentwith the same fallbacks as the currency creator's Next button. Complete isisProfileComplete(MenuScreenViewModel.kt:267): profile photo, cover photo and a bio that isn't blank. Favorite chats don't count. A "Favorite Community Chats" section shows "None yet" when empty.OwnProfileStateTestcovers each combination.PresentDepositOptions(USERNAME_SHORTFALL)) and Dismiss.Behaviour to check in review:
usernameMinBalanceuser flag, viausernameGate(), not a client constant. A zero or unresolved minimum opens the username editor with no modal.title_featuredGroupsnow reads "Favorite Community Chats" and its placeholder "Add chats".value_featuredGroupCountstill reads "N groups".#b0c6ff.