Repository navigation
feat(onboarding): new-user onboarding tweaks - #1139
Merged
Merged
Conversation
A new account finishing onboarding now opens on Chat, the tab every other login already opens on, instead of Money (node 12527:81350). HomeTab.postOnboarding existed only so onboarding could pass .wallet to completeLogin, so it goes, along with the landingTab parameter and SessionAuthenticator.landingTab that carried it. HomeTabView always opens on HomeTab.initial.
The new-user wallet loses the "Send Your First Tip" checklist and keeps one row, "Add Money / Add money to your account", which opens Add Money (node 12527:81782). It hides once the user has added money, the same point the wallet tiles appear, so the row and the tiles never show together. AddMoneyRowState replaces NewUserTutorialState. Tipping no longer feeds the wallet, so Session.hasEverTipped and Database.hasEverTipped are deleted along with TutorialChecklistCard.
Frame 12 (node 12527:81838) changes the You tab for a new account: - "Claim your username" is gone from the header. The username can still be set from Edit Profile. - The edit button reads "Complete Your Profile" on the system blue fill until the profile has a photo, a cover photo and a non-blank bio, then goes back to the gray "Edit Profile". Username and favorites do not count. - The featured-groups section is titled "Favorite Community Chats" everywhere. On the own profile it shows "None yet" when empty, but only once the favorites read has succeeded (or there is no username to read with), so an account with favorites never flashes the empty line.
Frame 13 (node 12527:81886) changes Edit Profile: - The cover chip reads "Add cover photo" and the avatar caption "Add profile photo" until each is set, then "Change cover" / "Change photo". - "Claim your username" is gone. The Username row shows the current @handle, auto-assigned or chosen, or "Add a username" when there is none. - The gate dialog reads "$100 Balance Required" with the body "Setting a custom username requires a balance of $100 or more" and the buttons "Add Money" and "Dismiss". The amount comes from the server flag; formattedDroppingZeroFraction() keeps "$100" whole and "$12.50" at two digits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New users now land on Chat after onboarding, see only the Add Money row on Money, get a "Complete Your Profile" prompt on You, and set a username from a plain row on Edit Profile. Design: "(Ted) Tweak Screens For New User [Oct 22]", node 12527:81344, frames 10–13. Android ships the same change in code-payments/code-android-app#1862.
One commit per change:
HomeTab.initialis.chat, andHomeTabViewalways starts there. The post-onboarding landing tab (HomeTab.postOnboarding,landingTab,HomeTabView(initialTab:)) is gone, so new and returning users take the same path.HomeTabLandingTestspins it, and bothCreateAccountSmokeTeststests now assert the Chat tab is selected.AddMoneyRowStateTestscovers when the row shows.Profile.isComplete: profile photo, cover photo and a bio that isn't blank. Favorite chats don't count. A "Favorite Community Chats" section shows "None yet" when empty.ProfileCompletenessTestscovers each combination.usernameRowDestination(needsClaim:gate:), tested inUsernameGateTests.Behaviour to check in review:
userFlags.usernameMinBalance, not a client constant. A zero or missing flag shows no modal.