Skip to content

fix(chat): match new group form titles to their New Chat rows #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Oct 29, 2026
+7 −7
Merged

fix(chat): match new group form titles to their New Chat rows #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Flipcash/Core/Navigation/AppRouter+Destination.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,9 @@ extension AppRouter {
case usernameLookup
/// The list of ways to start a chat, pushed from the Chats tab's `+`.
case newChat
/// The "New Public Group" form, opened from the New Chat screen.
/// The "New Community Chat" form, opened from the New Chat screen.
case newPublicGroup
/// The "New Private Group" form, opened from the New Chat screen.
/// The "New Group" form, opened from the New Chat screen.
case newPrivateGroup
/// A tip DM conversation, pushed onto the `.tips` stack — from the
/// Tips list or a tip-DM push notification.
Expand Down
4 changes: 2 additions & 2 deletions Flipcash/Core/Screens/Main/Tips/New Group/NewPublicGroupModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import FlipcashCore
/// this is a programming error rather than something the screen puts in front of the user.
struct NewPublicGroupIncomplete: Error {}

/// Everything the "New Public Group" form holds while it is being filled in, and the one call that
/// submits it (node 10127:118014). With ``GroupPrivacy/private`` it backs the "New Private Group"
/// Everything the "New Community Chat" form holds while it is being filled in, and the one call that
/// submits it (node 10127:118014). With ``GroupPrivacy/private`` it backs the "New Group"
/// form instead (node 11203:65): the same name and picture, no balance requirement, and a second
/// step that stores the host's chat key.
///
Expand Down
6 changes: 3 additions & 3 deletions Flipcash/Core/Screens/Main/Tips/New Group/NewPublicGroupScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import FlipcashUI

private let logger = Logger(label: "flipcash.new-public-group")

/// The "New Public Group" form: a name, an optional picture, and the balance a member has to hold
/// to get in (node 10127:118014). For ``GroupPrivacy/private`` it is "New Private Group" (node
/// The "New Community Chat" form: a name, an optional picture, and the balance a member has to hold
/// to get in (node 10127:118014). For ``GroupPrivacy/private`` it is "New Group" (node
/// 11203:65): no balance requirement, and a note on what privacy means instead.
struct NewPublicGroupScreen: View {

Expand Down Expand Up @@ -74,7 +74,7 @@ struct NewPublicGroupScreen: View {
.onChange(of: communityCurrencies, initial: true) { _, currencies in
model.applyDefaultCurrency(from: currencies)
}
.navigationTitle(model.privacy == .private ? "New Private Group" : "New Public Group")
.navigationTitle(model.privacy == .private ? "New Group" : "New Community Chat")
.navigationBarTitleDisplayMode(.inline)
.toolbar {
ToolbarItem(placement: .topBarTrailing) {
Expand Down
Loading