fix(vaultsfyi): bind execute_step network to the wallet chain - #1410
Open
SashaMIT wants to merge 1 commit into
Open
fix(vaultsfyi): bind execute_step network to the wallet chain#1410SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Reject execute_step when args.network differs from the wallet chain, mirroring the existing claim_rewards guard so agents cannot fetch and send wrong-network vault calldata on the connected wallet.
🟡 Heimdall Review Status
|
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execute_stepaccepted an agent-chosennetworkand fetched/executed vaults.fyi actions without checking the connected wallet chain. Siblingclaim_rewardsalready rejects cross-network claims.chainId, and reject whenargs.networkdoes not match it (before any API call orsendTransaction).Sibling of #1409 (CDP Permit2 / swap-submit retry). Same dogfood pass, different provider and root. Does not reopen that PR's findings.
Test plan
pnpm exec jest --testPathPattern='vaultsfyi/vaultsfyiActionProvider' --coverage=false(28/28)args.networkvs wallet chain returns the claim_rewards-style error and does not call fetch/sendTransactionchainIdreturnsInvalid networkMade with Cursor