Repository navigation
Stop tracking .claude/settings.json; run BiocCheckGitClone in CI again - #809
Merged
Merged
Conversation
BiocCheck 1.49 (Bioc 3.24) errors on Git-tracked .claude/ files. Following "Migrating a package that tracks .claude/" in r-bioc-dev-standards v1 (issue #8), the package now keeps only its own rules in dev/claude-settings.json (extra make targets, git fetch compbiomed, and people-only denies); make claude-setup merges them with the shared settings into the untracked .claude/settings.json. The Write() rules are not carried over, as the shared settings dropped them. .worktreeinclude makes Claude Code copy the gitignored settings into new worktrees, and AGENTS.md now tells Claude to stop in a clone that hasn't run make claude-setup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reverts the BiocCheck part of 14fc41e (#807). That stopgap ran BiocCheck on the built tarball only because the repo tracked .claude/settings.json; now that it doesn't, BiocCheck(".") runs BiocCheckGitClone on the repo again. ADR 0007 (still Proposed) drops the matching bullet and keeps the OpenSSL include-path change from the same commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #809 +/- ##
=======================================
Coverage 53.26% 53.26%
=======================================
Files 80 80
Lines 13360 13360
=======================================
Hits 7116 7116
Misses 6244 6244 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Pulling this branch deletes your
.claude/settings.json. Git removesthe file because it is no longer tracked. Without it, Claude Code runs with
neither the shared standards nor the permission guardrails. After you pull
(or merge
develinto your branch), every developer must runin a terminal outside Claude Code (not with
!, which runs insideClaude Code and is refused), then restart
claude. Do it once in each cloneand worktree you use.
What changed and why
BiocCheck 1.49 (Bioc 3.24) reports Git-tracked
.claude/files as an error.This follows "Migrating a package that tracks
.claude/" inr-bioc-dev-standards v1
ADOPTING.md(campbio/r-bioc-dev-standards#8).dev/claude-settings.json(new): holds only this package's own rules,the ones the shared
shared/claude-settings.jsonlacks:make help,make build,make app,make test-app,git blame, andgit fetch compbiomedgit push --force-with-lease,make site, andrm -frmake claude-setupmerges it with the shared settings into.claude/settings.json. The oldWrite(...)denies are not carried overbecause the shared settings dropped them.
.gitignore:.claude/settings.local.jsonbecomes.claude, and.claude/settings.jsonis no longer tracked(
git rm -r --cached .claude)..worktreeinclude(new): Claude Code copies the gitignored.claude/settings.jsoninto new worktrees. It's added to.Rbuildignore.AGENTS.md: tells Claude to stop and ask formake claude-setupwhenthe standards are missing from its context.
CI: reverts the stopgap from Run CI against Bioconductor devel; fix macOS and batchelor warnings #807 (14fc41e), so
BioC-check.yamlruns
BiocCheck(".")on the Git checkout again. On a Git clone that alsoruns
BiocCheckGitClone. ADR 0007 (still Proposed) drops the tarballbullet and keeps the OpenSSL include-path change from the same commit.
How it was tested
make claude-setup, the generated settings match the old fileexcept for: entry order (package rules now come after the shared ones),
the 13
Write(...)denies that were dropped on purpose, and three newshared denies (
Edit(dev/claude-settings.json),make claude-setup).The hooks are unchanged.
make bioccheckin a clean clone of this branch:optional CITATION.
this PR (no R code changed):
(release), so it treats the devel version 2.23.6 as a release version.
class() ==inplotSCEHeatmap.R: existing code..Deprecated/.Defunctcount: existing code.scans the gitignored local
.worktrees/checkouts. CI has no.worktrees/..claude/rule. This PR's BioC-check job (Bioc devel, BiocCheck 1.49) is the real
test of that rule.
Checklist
make testpasses, andmake coveragedidn't drop (N/A: no R code changed)
make check-fullandmake bioccheckpass with no new errors or warningsmake docsrun, if roxygen comments changed (N/A)_pkgdown.yml, andmake site-checkpasses (N/A)user-facing)
/code-reviewrun; findings fixed or answeredADR
Amends the Proposed
dev/adr/0007-ci-against-bioc-devel.md(removes the"Run BiocCheck on the built tarball" bullet). Otherwise N/A.
Scientific correctness
Generated content
Claude Code wrote all of it: the settings migration, the AGENTS.md
paragraph (copied from the standards template), the CI revert, and this
description. The maintainer ran
make claude-setup.🤖 Generated with Claude Code