CHG: Account for dead and double-wide strips in MModuleDepthCalibration - #206
Merged
ckierans merged 6 commits intoSep 15, 2026
Merged
Conversation
…MModuleDepthCalibration`
fhagemann
commented
Sep 6, 2026
MModuleDepthCalibrationMModuleDepthCalibration
Author
Author
|
This is ready for review now. |
ckierans
approved these changes
Sep 15, 2026
ckierans
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, Felix! I like the simplicity of the shorted strip handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #157
In this PR, I am proposing a convention for disabled strips, both (dead and double-wide).
How to define disabled strips in a CSV file
The format to describe disabled strips proposed here takes the form
Det ID, Side, Disabled Strip, [Read-out via]:I have added files for all COSI SMEX flight detectors to
resource/calibration/COSISMEX/unitand a combined one based on all unit-level calibration files toresource/calibration/COSISMEX/payload.Note that most of these have HV strip 31 disabled (due to being tested with a faulty NICEv1 board)
What is changing in
MModuleDepthCalibrationThe depth calibration assigns the X and Y position as the center of the strip. For double-wide strips, this used to place the hits wrongly in the center of the strip that was read out, instead of at the center of the double-wide strip.
With the changes in this PR, we are now assigning hits in double-wide strips to the center of the double-wide strip, and we are also doubling the uncertainty on that position to account for the doubled strip width.
We are also not attempting any depth reconstruction for dead strips.
Accounting for disabled strips is optional and can be omitted using a check button, or by passing either no file name at all or a CSV file name pointing to an empty file:

What about the DEE?
I would like to discuss the current format of defining double-wide strip and get it approved in this PR, before tackling the DEE (probably in a follow-up PR).
For the DEE, I envision replacing finding dead strips (currently done by checking which strips do not appear in the energy calibration file) with the dead strips in this file, and do some more accurate charge sharing in
SubModuleChargeTransportfor double-wide strips.