Repository navigation
test(voice): judge pipelined synthesis by what was heard, not by the player's state - #21
Merged
Merged
Conversation
…player's state TestVoiceSpeaksTheFirstSentenceWhileTheRestRenders asked whether the player was busy the moment the second synthesis request arrived. That request leaves as the first piece's audio arrives, before the piece is cleaned and handed to the player, so the answer was a race. clear_voice put a band-pass and a leveller in that gap, and under -race it was wide enough to lose every time on CI. The test now checks that the speakers had not yet heard the whole first piece, which is the claim it exists to make, and it still fails against a speak that renders serially. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KGraEtxbWFphuCAfsNSYNb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestVoiceSpeaksTheFirstSentenceWhileTheRestRenders asked whether the player
was busy the moment the second synthesis request arrived. That request
leaves as the first piece's audio arrives, before the piece is cleaned and
handed to the player, so the answer was a race. clear_voice put a band-pass
and a leveller in that gap, and under -race it was wide enough to lose every
time on CI. The test now checks that the speakers had not yet heard the whole
first piece, which is the claim it exists to make, and it still fails
against a speak that renders serially.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01KGraEtxbWFphuCAfsNSYNb