Skip to content

test(voice): judge pipelined synthesis by what was heard, not by the player's state #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webpolis merged 1 commit into from
Oct 3, 2026
Merged

test(voice): judge pipelined synthesis by what was heard, not by the player's state #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions internal/channel/voice/voice_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,14 +1550,18 @@ func TestVoiceSpeaksTheFirstSentenceWhileTheRestRenders(t *testing.T) {
h.mu.Lock()
h.reply = "Claro que sí, ahora mismo lo veo. La respuesta es que mañana llueve por la tarde. Llevá paraguas."
h.mu.Unlock()
h.setReplyPCM(make([]byte, playbackRate*2)) // a second of audio per piece, paced in real time
piece := playbackRate * 2
h.setReplyPCM(make([]byte, piece)) // a second of audio per piece, paced in real time
h.start()
h.say()
h.turn(10 * time.Second)

// The second request leaves as the first piece arrives, before it is
// cleaned and handed to the player, so whether the player has started
// yet is a race; what the speakers had heard of the first piece is not.
waitUntil(t, func() bool { return len(h.synthesized()) >= 2 })
if !h.v.player.busy() {
t.Error("the second piece was requested only after the first had been heard out")
if heard := len(h.speaker.heard()); heard >= piece {
t.Errorf("the second piece was requested only after the first had been heard out (%d of %d bytes)", heard, piece)
}
want := []string{
"Claro que sí, ahora mismo lo veo.",
Expand Down
Loading