Skip to content

Upgrade framework and content-version website assets - #200

Closed
dblock wants to merge 1 commit into
masterfrom
upgrade/framework-assets-230
Closed

dblock wants to merge 1 commit into
masterfrom
upgrade/framework-assets-230

Conversation

@dblock

@dblock dblock commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Summary

Implemented by GitHub Copilot (AI), on behalf of @dblock.

Upgrade rack-server-pages to 0.3.0 and slack-ruby-bot-server to 2.3.0. Only those two resolved gem versions change; preserve Ruby, Stripe, OAuth v1, RTM, calendar, stats, API routes, existing artwork/layout, and the Sup2 redirect.

Version local website scripts, styles, images, favicons, fonts, and checkout artwork by content. Render CSS with nested local assets as ERB at the original CSS URLs, so an artwork-only change changes the rendered background URL even when the stylesheet source is unchanged. Convert the scripts partial to ERB and update all references. Correct the existing Android favicon reference to its local asset while versioning it.

Apply central private, no-cache to templates and generated CSS through the actual custom middleware callback. Keep static content ETags and timestamp defaults, with no long-lived or immutable caching. Document helper usage and policy.

Validation

  • bundle exec rubocop -a and bundle exec rubocop --auto-gen-config: pass; no new exclusions or raised limits.
  • Focused actual-stack, nested-artwork/cache regressions, and Firefox image/background loading with dimensions after reload: 10 examples, 0 failures, port 9434.
  • Full RSpec: 552 examples, 1 failure, 4 existing pending. The unchanged date-sensitive spec/models/team_spec.rb:491 fails across the upcoming November DST transition; confirmed on a narrow retry. Scheduling behavior and that unrelated test are not changed here.
  • Dedicated local test database: slack_sup_framework_assets_test.

Built on freshly fetched master in an isolated worktree. The original checkout and its unrelated branch are untouched.

@dblock

dblock commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Hosted validation is complete: RuboCop passed; RSpec failed only at the unchanged DST-sensitive scheduling example spec/models/team_spec.rb:491 (545 examples, 1 failure, 4 pending). Both push and PR runs show the same pre-existing failure as the local full suite and narrow retry. New asset/cache/browser regressions pass. No scheduling code or unrelated tests were changed.

@dblock
dblock force-pushed the upgrade/framework-assets-230 branch from a0bae30 to 0cb2c27 Compare October 25, 2026 21:52
@dblock

dblock commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Final formatting-only commit 0cb2c27 is verified: both RuboCop checks passed; both RSpec checks finished with the same unchanged scheduling/DST failure at spec/models/team_spec.rb:491. All new asset/cache/browser tests pass. Changelog prose remains unwrapped with no extra blank line after the new entry.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock
dblock force-pushed the upgrade/framework-assets-230 branch from 0cb2c27 to 8cc93c8 Compare October 25, 2026 22:38
@dblock

dblock commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Closing without merging, all development moves to slack-sup2.

@dblock dblock closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant