Repository navigation
Conversation
… server pages. Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
Collaborator
|
Thanks for this. You've clearly tested it thoroughly (the real We're holding off on merging this version for two reasons:
Suggested way forward:
If server-side use of the formatters turns out to matter later, we can revisit it with a concrete case. Happy to review both! |
…ent-boundaries Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
5 tasks done
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive registry entries installed with
shadcn addfail when rendered from a Next App Router server page because they lack a client boundary. Copied documentation examples also lose their existing"use client"directive.Add
"use client"to the seven interactive entries and preserve it in copied example source. Keep the existing single-file component structure and registry format. The net change against currentdevis 9 files, 17 additions and 4 deletions; it includes a short note explaining that function-valued glyph figures belong inside client components.The branch includes current
dev(9f36ea24), including #48's animation scheduling changes. Each of the seven component/block implementations matches that upstream version except for the added directive. TurnStatus accessibility changes are being reviewed separately.formatDurationandcompactTokensremain exports of their component modules, which are now client modules. Invoke those helpers from client code. This intentionally accepts that direct server invocation of these undocumented exports is no longer supported; no formatter compatibility split or extra installation manifest is included.Validation:
npm run docs,npm run typecheckandnpm run buildpass; generatedregistry.jsonis unchanged.shadcn addfrom this branch's registry. Its server routes render the agent components and workspace; its client probe exercises Composer, AskCard,useElapsed, both formatter exports, and stock/custom glyph figures. Compilation, strict TypeScript, prerendering and production browser interactions pass without page errors.patchStatsremains callable on the server.