fix(azure): scope the budget to eagle-analytics resources - #8
Merged
Merged
Conversation
The budget had no filter, so it measured the whole shared resource group and fired all three alerts on 2026-09-06. Filter on the Application tag that every estate resource already carries.
Review finding: the tag key was a literal, so a rename in defaultTags would leave a budget that matches nothing. Both key and value now come from the same object, and empty values fail the build. Also note the /api/usage browser prefix in MIGRATION.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analytics-budget-<env>had no filter, so it measured the whole shared resource group (about 150 CAD/month baseline against a 60 CAD budget) and fired Actual 80 %, Actual 100 % and Forecasted 100 % on 2026-09-06.The budget now filters on the
Applicationtag thatdefaultTagsstamps on every estate resource.startDateis unchanged, so the deploy updates the budget in place.Deploy:
scripts/deploy-infra.sh test --liveby the operator (what-if needs the secret exports).