feat(manipulation): add grasp proposal pick pipeline - #3276
Draft
TomCC7 wants to merge 2 commits into
Draft
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
add-grasp-pipeline-skillProblem
GraspGenX can propose grasps, but the manipulation stack did not carry a proposal through object resolution, collision-aware feasibility checks, physical execution, and grasp verification.
Solution
pickthrough object point-cloud validation, ranked GraspGenX proposals, and pre-grasp/grasp/retreat feasibility checks.xarm-graspgenxandxarm-graspgenx-agentblueprints while preserving explicit heuristic fallback in existing xArm stacks.The closure-position verification path is implemented, but it remains disabled in the hardware blueprint until the xArm threshold is calibrated. GPU startup and guarded physical-xArm scenarios also remain open in the OpenSpec checklist.
How to Test
Run the feature on a GPU-equipped xArm host:
Validation completed locally:
Results: 78 focused tests passed; 415 broader manipulation tests passed with 13 skipped and 12 deselected. Ruff formatting and lint checks passed.
AI assistance
Codex with GPT-5 implemented the change, wrote tests and documentation, and ran validation. The author should review and understand every line before merging.
Checklist