Skip to content

Fix for nix - #3281

Merged
leshy merged 2 commits into
mainfrom
andrew/feat/include-nix-logs
Jul 30, 2026
Merged

Fix for nix#3281
leshy merged 2 commits into
mainfrom
andrew/feat/include-nix-logs

Conversation

@aclauer

@aclauer aclauer commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Contribution path

  • Small, safe change that does not need a tracking issue
  • Linked issue or discussion: DIM-XXX / #XXX / URL

Problem

Nix native module builds don't emit logs by default

Solution

add -L

How to Test

AI assistance

Checklist

  • I have read and approved the CLA.

@mintlify

mintlify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
dimensional 🟢 Ready View Preview Jul 30, 2026, 12:41 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3281   +/-   ##
=======================================
  Coverage   75.20%   75.20%           
=======================================
  Files        1128     1128           
  Lines      107954   107954           
  Branches     9751     9751           
=======================================
+ Hits        81188    81190    +2     
+ Misses      23955    23954    -1     
+ Partials     2811     2810    -1     
Flag Coverage Δ
OS-ubuntu-24.04-arm 68.85% <100.00%> (ø)
OS-ubuntu-latest 70.92% <100.00%> (+<0.01%) ⬆️
Py-3.10 70.92% <100.00%> (-0.01%) ⬇️
Py-3.11 70.90% <100.00%> (-0.02%) ⬇️
Py-3.12 70.91% <100.00%> (-0.01%) ⬇️
Py-3.13 70.91% <100.00%> (-0.01%) ⬇️
Py-3.14 70.92% <100.00%> (ø)
Py-3.14t 70.92% <100.00%> (+<0.01%) ⬆️
SelfHosted-Large 29.10% <ø> (+0.01%) ⬆️
SelfHosted-Linux 35.65% <100.00%> (-0.01%) ⬇️
SelfHosted-macOS 34.71% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/hardware/sensors/lidar/fastlio2/module.py 89.15% <100.00%> (ø)
dimos/hardware/sensors/lidar/livox/module.py 93.02% <100.00%> (ø)
dimos/hardware/sensors/lidar/pointlio/module.py 91.96% <100.00%> (ø)
...os/hardware/sensors/lidar/virtual_mid360/module.py 51.85% <100.00%> (ø)
dimos/mapping/ray_tracing/module.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aclauer
aclauer marked this pull request as ready for review July 30, 2026 01:36
@aclauer
aclauer enabled auto-merge July 30, 2026 01:36
@aclauer
aclauer added this pull request to the merge queue Jul 30, 2026
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Jul 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 30, 2026
@leshy
leshy added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit ec4e9c9 Jul 30, 2026
37 checks passed
@leshy
leshy deleted the andrew/feat/include-nix-logs branch July 30, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants