Add smaller fixes to make running from files more robust - #15
Conversation
…nt skip out on forecasts on the borders of the domain near sunset/sunrise
|
Thanks a lot @JoachimKoenigslieb, this is awesome! |
|
In general, I think that support for reading in data from GRIB files would also be nice. Is it correctly understood, that this would require only |
|
The command: |
|
All implemented functionality seems to work as intended! This is great! |
AdamRJensen
left a comment
There was a problem hiding this comment.
I left a few comments, but my main concern that I want to raise is that climatological clear sky models as used in this PR are not ideal for forecasting applications given that water vapor varies significantly from day to day. But if this is for testing purposes, then it's fine to add.
Using CAMS clear sky data based on forecasting of aerosols is the way forward in my opinion.
Co-authored-by: KristianHMoller <150110122+KristianHMoller@users.noreply.github.com>
Co-authored-by: KristianHMoller <150110122+KristianHMoller@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
|
Have been a bit swamped with other things but have not forgotten about this MR! Will apply all suggestions and get it ready. |
|
Thanks for the update @JoachimKoenigslieb However the main |
I wanted to use
sunflowto do nowcasting over the US with data from GOES.I ultimately get the data from this public AWS source here https://registry.opendata.aws/noaa-goes/.
Unfortunately my files are stored converted to grib2, so I'm getting into some quite off-label usage here. Maybe this is not something you guys are interested in supporting up stream here? The specific changes needed to support it are quite general and feels like reasonable changes tough.
Turns out that xarray is happy enough to read my files out of the box if I install
cfgribas a peer-dependency ofsunflow. One big issue remains: I'm not storing the clearsky in these grib2 files! Instead I made a small config switch that allows for fetching the clearksy via the already-installedpvlib.A list of fixes implemented are:
.expand_dimsinstead of.assign_coordsto make sure we have both time dimension AND time coordinates when loadingmake_pvlib_clearsky_datasetwhich makes clearsky by callingpvlib. Also added a new config variableclearsky_sourcewhich defaults tofileand switches behavior when set topvlib.check_solar_elevationnow does not take Copenhagen as a default as that can easily lead to silent buggy behavior.With these changes I'm able to do nowcasts over CONUS:
