Skip to content

Reorder attachments with steppers, not only with drag - #355

Open
dmnyc wants to merge 1 commit into
fix/poll-media-exclusivefrom
fix/thumb-reorder-steppers
Open

dmnyc wants to merge 1 commit into
fix/poll-media-exclusivefrom
fix/thumb-reorder-steppers

Conversation

@dmnyc

@dmnyc dmnyc commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Fixes #346. Stacked on #354 (→ #353#352#351#341) — the diff shown here is just this fix.

HTML5 drag-and-drop never fires on touch, so a touchscreen had no way to reorder attachments and a keyboard had none either. The steppers are the cheapest reorder that always works: small ◀/▶ buttons on each thumbnail's bottom corners (buttons — reachable by touch and Tab), splicing the same array the drag does, so everything downstream is identical either gesture. The ends hide their arrow rather than disabling it; a new arrow-right icon mirrors the existing left one rather than rotating it (the join reads wrong at 14px).

The steppers flush the ALT row before splicing (the drag's rule) and square with the remove disc in Werkstätte, whose circular-things exception list now includes them.

HTML5 drag-and-drop never fires on touch, so a touchscreen had no way
to reorder attachments at all, and a keyboard had none either. The
steppers are the cheapest reorder that always works: two small buttons
on the thumbnail's bottom corners, reachable by touch and Tab both,
splicing the same array the drag does — the appended URLs, the imeta
tags and the drawer rows follow either gesture identically. The ends
hide their arrow rather than disabling it, because a greyed-out control
is an answer to a question nobody asked.

The steppers flush the ALT row before they splice, the same rule the
drag learned: the row's slot is still where it was opened, and after
the move it would not be. And they square with the remove disc in
Werkstätte, whose exception list every circular thing answers to.

Fixes #346.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant