Give the attach offer a way to be told no - #356
Merged
Merged
Conversation
The offer stands while the URL line stands — that is what keeps it from vanishing under the typing — but a user who means the URL as prose was left with an accented row indefinitely and no answer to it, short of editing the line away. The ✕ beside the offer is that answer. It dismisses for this URL only, and the dismissal expires with the line: paste the same URL afresh later and the question is asked again, so a deliberate no is not a forever no. The refusal is the quiet control on the row — the accent belongs to the offer, not to turning it down. Fixes #347.
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #347. Stacked on #355 (→ … → #351 → #341) — the diff shown here is just this fix.
The offer stands while the URL line stands — that's what keeps it from vanishing under typing — but a user who means the URL as prose was left with an accented row indefinitely and no answer to it.
The ✕ beside the offer is that answer ("Keep it as text"): dismisses for this URL only, and the dismissal expires when the line does — paste the same URL fresh later and the question is asked again. A deliberate no is not a forever no, and withdraw-on-keystroke stays dead. The refusal is the quiet control on the row; the accent belongs to the offer.