fix!: prepare 3.0.0 with semicolon CSV default - #6
Merged
Merged
Conversation
Align omitted CSV delimiters with the backend default. Callers that need comma-separated output must select CsvDelimiter.COMMA explicitly.
Use a major version for the changed CSV default and document how to preserve comma-separated exports.
StefaniOSApps
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare Python client 3.0.0: meter-reading CSV exports without an explicit delimiter use
semicolon, matching the backend's existing default. Previously, the client sentcomma.This changes the output of existing calls that omit the delimiter, so the release uses a new major version. To retain the 2.x output, pass
delimiter=CsvDelimiter.COMMAinExportMeterReadingsDto. The README includes this migration note. Explicit comma, semicolon and tab remain supported; other resources and export options are unchanged.Update the shared Python/TypeScript contract fixtures, including CSV bytes, and cover explicit comma and tab selections alongside the existing semicolon case.
Validation:
make allpasses with 402 tests, Black, isort, mypy, coverage, distribution validation and isolated installation of the 3.0.0 wheel. The release check acceptsv3.0.0. No tag or publication is performed by this PR update.