Skip to content

decision(delete-user-data): kit/extension parity – blank required params fail the kit deploy, the extension uses defaults #3256

Open

Description

@CorieW

delete-user-data kit/extension parity. Priority: low. A config that works on the extension fails to deploy as a kit.

Difference

  • Extension: a blank required param falls back to its declared default.
  • Kit: assertRequiredParams() stops the deploy with Required parameters are set to an empty value: …. That check came from c924239, which assumed the extension refuses blank values.

Reproduced

  • Extension: reconfigured through the CLI with FIRESTORE_DATABASE_ID=, FIRESTORE_DELETE_MODE= and AUTO_DISCOVERY_SEARCH_DEPTH=. The deploy succeeded, and the instance stored (default), shallow and 3.
  • Kit: the same .env fails discovery with the error above.

Code

Resolution

Two options:

  • Treat a blank value the same as an unset one and apply the default, to match the extension.
  • Keep the stricter check and record it as an accepted difference under "Decisions" in delete-user-data kit tracking issue #3249.

This check is shared by all kits, so the decision applies to all of them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    decisionNeeds a decision before work can proceedkitsparity

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions