Repository navigation
delete-user-data kit tracking issue #3249
Copy link
Copy link
Open
0 / 140 of 14 issues completedDescription
Tracks parity between the delete-user-data extension (0.1.30) and the @firebase-function-kits/delete-user-data kit.
How it was tested: both deployed side by side on a test project with matching configs, then compared on data deleted, events, Pub/Sub messages, logs, runtime settings, install and uninstall. Kit tested at kits @ fcdd555, installed three ways: the README's manual setup, functions:kits:install, and ext:migrate.
Sub-issues are ordered by priority, highest first.
Issues labelled decision need a call: change the kit, or record the difference as accepted in the below "Decisions" section.
Decisions
None yet
Intentional Differences
- 2nd gen only: all three functions are 2nd gen, so
clearDatalistens on the 2nd gen Auth eventgoogle.firebase.auth.user.v2.deletedinstead of the 1st genuser.deletetrigger. - Instance id and topics: the instance id comes from
firebase.json(FIREBASE_KIT_INSTANCE_ID), and the Pub/Sub topics arekit-<id>-discovery/kit-<id>-deletioninstead ofext-<id>-*. - Region: there's no install-time location. Set it with
setGlobalOptions({ region }); thefunctions:kits:installandext:migratetemplates do this fromFUNCTION_DEFAULT_REGION. Otherwise the functions deploy tous-east1. - Max instances: 2nd gen defaults to 100 instances per function, against 3000 for the extension's 1st gen functions. Raise it with
setGlobalOptions({ maxInstances }). - Ingress: all three functions are always
ALLOW_INTERNAL_ONLY, the extension's default. The extension's install-time ingress setting doesn't carry over:setGlobalOptions({ ingressSettings }), whichext:migrateuses for it, doesn't change the kit's ingress (fix(delete-user-data): kit/extension parity – kit silently skips deletions under load (concurrency 80 OOM) #3250). - Eventarc channel: the kit doesn't create the channel. It must exist before
EVENTARC_CHANNELis set. - Failure status: 2nd gen request logs show HTTP 200 for failed and timed-out runs, and there's no
status: 'error'/'timeout'line. Failures only show up in the logs (as ERROR entries once fix(delete-user-data): log failed kit runs at ERROR severity #3282 lands). - When param values are checked: the extension checked each value once, when it was installed or reconfigured. The kit has no install step, so it checks the same values every time it's deployed or loaded in the emulator, and a bad value fails that deploy. It accepts and rejects the same values as the extension, option labels included (once fix(delete-user-data): reject invalid select and regex param values at deploy #3278 lands).
Reactions are currently unavailable
Activity
fix(delete-user-data): reject invalid select and regex param values a…