Skip to content

decision(delete-user-data): kit/extension parity – startup config log is lazy and uses different keys #3257

Open

Description

@CorieW

delete-user-data kit/extension parity. Priority: low. This only affects anything that parses the startup config log.

Difference

  • Extension: logs Initializing extension with configuration on each cold start, when the module loads. The keys are databaseId, enableSearch, storageBucketDefault, selectedDatabaseInstance, discoveryTopic and so on.
  • Kit: logs it on the first event an instance handles. The keys follow the kit's resolved config: firestoreDatabaseId, enableAutoDiscovery, storageBucket, rtdbInstance, discoveryTopicName, plus instanceId and projectId. All other log lines match the extension's word for word.

Reproduced

Compared Cloud Logging output for the same deletion on both sides.

Code

Resolution

Record it as an accepted difference under "Decisions" in #3249. The config is resolved lazily, and the key names are the kit's public ResolvedDeleteUserDataConfig type. Renaming the keys just for log parity isn't worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    decisionNeeds a decision before work can proceedkitsparity

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions