Repository navigation
docs(storage-resize-images): document the kit's event source - #3306
Draft
IzaakGough wants to merge 2 commits into
Draft
IzaakGough wants to merge 2 commits into
IzaakGough wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for the storage-resize-images kit to document the differences in the event source format between the extension and the kit. It explains how the event source format changes and provides guidance on updating triggers or using EVENTARC_CHANNEL to avoid issues. There are no review comments, and the changes look correct and clear, so there is no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3272.
A trigger that filters on the extension's event
sourcestops receiving events after moving to the kit, with no error.This documents the new
sourcevalue under the differences from the extension, and how to tell instances apart instead.firebaseextensions.googleapis.cominstance URI, which the kit should not claim.Checked against the firebase-tools and firebase-admin source and the values measured in the issue. Not redeployed.