fix: resolve lodash functions via named entry points, not named imports - #271
Merged
Conversation
lodash is CommonJS with no static named exports, so `import {map} from
'lodash'` breaks under any consumer resolving it through native ESM
(e.g. Vitest), now that this package declares "type": "module". Import
each function from its own entry point instead.
|
PR checklist
|
cdmren
marked this pull request as ready for review
August 24, 2026 20:51
cdmren
enabled auto-merge
August 24, 2026 21:05
joris974
approved these changes
Aug 25, 2026
joris974
left a comment
Member
There was a problem hiding this comment.
Good. I am pretty sure we can remove lodash and use native JS functions for many of the usecase here (map, find, reduce, forEach). identity is an interesting one I haven't used before
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270