Skip to content

Fix Win32 Weather fetch, image opacity, and file cache access - #1

Merged
dogukani merged 1 commit into
mainfrom
fix/win32-fetch-opacity-cache
Sep 23, 2026
Merged

dogukani merged 1 commit into
mainfrom
fix/win32-fetch-opacity-cache

Conversation

@dogukani

@dogukani dogukani commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The Windows Weather build receives a successful HTTP response but cannot read its body, so forecast values remain empty. Inactive weather images are still painted because the image path ignores node opacity. File-backed image/cache operations also stop at the mount check because the Windows target does not register a provider.

Changes

  • Leave WinHTTP automatic decompression disabled to avoid the observed E_ABORT body-read failure.
  • Pass image node opacity to AlphaBlend as SourceConstantAlpha, retaining 255 as the default for native Controls callers.
  • Register the Windows file-cache mount provider before app initialization.

Verification

  • Clean Weather builds with the original and changed network code: at frame 600, the original showed empty forecast values and the change showed live temperatures and hourly forecast.
  • With the network change held constant, the original image painter stacked inactive weather images; the changed painter showed only the active image.
  • A temporary runtime probe confirmed file-cache write/read success and expected failures for an invalid write path and missing read path. The probe was removed before the final clean build.
  • Clean Win32 smoke build and press check (Clicked 2); clean notes-jsx Windows build and screenshot capture.
  • git diff --check.

WinHTTP now returns explicitly compressed responses as encoded bytes. Transparent decompression for those responses is outside this fix.

Summary by CodeRabbit

  • Bug Fixes
    • Windows now applies configured opacity when rendering images, including fully transparent images.
    • Windows storage is available during application startup.
    • Windows network responses are no longer automatically decompressed by the networking layer.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d3d00aa1-9c77-449f-ab31-29b1c0ab2e65

📥 Commits

Reviewing files that changed from the base of the PR and between 0c02c6b and 680b5e0.

📒 Files selected for processing (5)
  • packages/geastack-windows/targets/win32/main/win32_main.cpp
  • packages/geastack-windows/targets/win32/main/win32_network.cpp
  • packages/geastack-windows/targets/win32/main/win32_renderer.cpp
  • packages/geastack-windows/targets/win32/main/win32_widgets.cpp
  • packages/geastack-windows/targets/win32/main/win32_widgets.h

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Windows target now registers a storage mount provider during boot, removes automatic decompression from its WinHTTP session, and passes image-node opacity into bitmap painting.

Changes

Windows storage initialization

Layer / File(s) Summary
Register the Windows mount provider
packages/geastack-windows/targets/win32/main/win32_main.cpp
The Windows target includes the platform file-cache header and registers a storage mount provider during boot. The provider returns success without performing a mount operation.

WinHTTP session configuration

Layer / File(s) Summary
Remove automatic decompression
packages/geastack-windows/targets/win32/main/win32_network.cpp
The session no longer enables WinHTTP decompression. The comments no longer list decompression among the system HTTP features.

Image opacity rendering

Layer / File(s) Summary
Pass opacity through bitmap painting
packages/geastack-windows/targets/win32/main/win32_renderer.cpp, packages/geastack-windows/targets/win32/main/win32_widgets.cpp, packages/geastack-windows/targets/win32/main/win32_widgets.h
paintBitmap accepts an optional opacity value, defaulting to 255. Image nodes pass their configured opacity. Bitmap painting skips drawing at zero opacity and uses the supplied value as AlphaBlend’s constant source alpha.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: dashersw

Merge Risk: ⚪ Minimal · up to 680b5

The Windows storage, fetch, and image changes have no established merge-blocking issue in the available evidence. Explicitly compressed responses still require separate handling.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the three main changes: Win32 weather fetching, image opacity, and file-cache access.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA.
Posted by the CLA Assistant Lite bot.

@dogukani

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@dogukani
dogukani merged commit e06836c into main Sep 23, 2026
3 of 4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 23, 2026
@dogukani
dogukani deleted the fix/win32-fetch-opacity-cache branch September 23, 2026 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant