Fix Win32 Weather fetch, image opacity, and file cache access - #1
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Windows target now registers a storage mount provider during boot, removes automatic decompression from its WinHTTP session, and passes image-node opacity into bitmap painting. ChangesWindows storage initialization
WinHTTP session configuration
Image opacity rendering
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Windows storage, fetch, and image changes have no established merge-blocking issue in the available evidence. Explicitly compressed responses still require separate handling. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
All contributors have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
Problem
The Windows Weather build receives a successful HTTP response but cannot read its body, so forecast values remain empty. Inactive weather images are still painted because the image path ignores node opacity. File-backed image/cache operations also stop at the mount check because the Windows target does not register a provider.
Changes
E_ABORTbody-read failure.AlphaBlendasSourceConstantAlpha, retaining 255 as the default for native Controls callers.Verification
Clicked 2); cleannotes-jsxWindows build and screenshot capture.git diff --check.WinHTTP now returns explicitly compressed responses as encoded bytes. Transparent decompression for those responses is outside this fix.
Summary by CodeRabbit