ref: attachment manifest - #2108
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
jpnurmi
force-pushed
the
jpnurmi/ref/attachment-manifest
branch
from
September 17, 2026 16:51
d8eb6bb to
f0d7bcf
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2108 +/- ##
==========================================
+ Coverage 75.15% 75.32% +0.16%
==========================================
Files 103 103
Lines 27930 27922 -8
Branches 5094 5100 +6
==========================================
+ Hits 20990 21031 +41
+ Misses 5596 5556 -40
+ Partials 1344 1335 -9 🚀 New features to boost your workflow:
|
jpnurmi
force-pushed
the
jpnurmi/ref/attachment-manifest
branch
from
September 18, 2026 15:35
f0d7bcf to
8166a35
Compare
jpnurmi
added this pull request to stack #2113
September 18, 2026 16:49
Use a shared MessagePack stream for attachment manifests. The native
backend uses the manifest for attachments generally, while both
out-of-process crash handlers can also use it for crash-time hint
attachments that cannot cross backend IPC. This lets Crashpad consume
those attachments without adding JSON support.
Stream attachment objects directly to avoid format-specific conversion
and buffer the complete manifest for a single file write. Median release
benchmarks measured write/read improvements over legacy JSON of 17%/6%
for one attachment, 74%/17% for 10, and 86%/24% for 100:
1 attachment 10 attachments 100 attachments
MessagePack write 2.3 us 2.4 us 11.8 us
JSON write 2.7 us 8.9 us 82.6 us
MessagePack read 1.3 us 5.6 us 54.1 us
JSON read 1.4 us 6.8 us 71.1 us
Keep legacy JSON compatibility private to the native daemon so it can
still consume manifests written by older SDK versions.
jpnurmi
force-pushed
the
jpnurmi/ref/attachment-manifest
branch
from
September 21, 2026 07:25
bebb882 to
6b691ac
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6b691ac. Configure here.
mujacica
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a MessagePack stream for
__sentry-attachments- the same file format we already use for__sentry-breadcrumbN. This lets Crashpad consume attachments with the existing MessagePack reader, without having to introduce JSON support/dependencies:__sentry-attachmentscrashpad#170The native backend currently uses the manifest for all attachments (changes in #1834), whereas crashpad only needs it for crash-time hint attachments (#2099) that cannot cross backend IPC.
As a bonus, the binary format is faster to serialize. Median benchmarks measured write/read improvements over legacy JSON of 17%/6% for one attachment, 74%/17% for 10, and 86%/24% for 100:
The legacy JSON format is kept private in the native daemon for compatibility, so it can still consume manifests written by older SDK versions.