feat: resolve crash-hint attachments from __sentry-attachments - #170
Merged
Merged
Conversation
Resolve final attachments from the `__sentry-attachments` manifest file if present. This makes it possible to modify attachments during crash handling via `hint` - IPC is not usable at that point. The manifest is only written if crash-time modifications are detected, and in that case it overrides/replaces the entire list of attachments to support all operations including clearing the attachments.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
mujacica
approved these changes
Sep 21, 2026
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve final attachments from the
__sentry-attachmentsmanifest file if present. This makes it possible to modify attachments fromon_crashduring crash-handling, when IPC is not available.💡 Notice that the fast async IPC route remains for normal runtime attachment changes. A sync manifest is only written if crash-time modifications via the
on_crashhook are detected, which is only possible for non-fastfail crashes. If/when the manifest is present, it overrides the entire list of attachments. This way, it supports all operations, including adding and removing individual attachments, and even clearing all attachments.Tested by and required for: