Repository navigation
test: add multi-queue worker coverage (framework#1564) - #153
Merged
Merged
Conversation
hwbrzzl
force-pushed
the
test-pr-1564-multi-queue-worker
branch
from
September 25, 2026 11:26
fed9afc to
be17d07
Compare
hwbrzzl
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"high,default") now drains higher-priority queues first regardless of dispatch order, and a no-argsWorker()consumes the configuredqueue.connections.*.queuelist.OnQueue()targets the first name in the configured list instead of the raw combined string, and failed jobs record the queue they were reserved from.default.Why
Framework#1564 adds support for multiple queues in the worker: a worker accepts a comma-separated queue list and polls it left to right as a priority order, and a queue connection can declare more than one queue name. This branch upgrades the example to a build carrying #1564 and adds an integration suite so the example stays a faithful, executable reference for the new semantics. With #1564 merged,
go.modnow tracks upstreamgithub.com/goravel/frameworkat the latest master (v1.18.1-0.20260925114822-dab1968caa54) andgo.sumwas regenerated withgo mod tidy; thereplacedirective is kept but repointed from the temporary fork to upstream.QueueMultiQueueTestSuitelocks the behavior in end to end: priority polling is proven to follow the queue list rather than insertion order, no-argsWorker()proves the configured list is consumed, default dispatch proves the first configured queue is targeted, failed jobs prove their reserved queue is attributed, and the normalization cases cover trim, empty-entry, and empty-list fallback.