Repository navigation
fix(tests): make the render-detail fixture's message interpreter-stable - #145
Merged
Merged
Conversation
test_the_render_error_detail_is_bounded_and_names_only_the_type asserted
'division by zero' in str(exc.__cause__) but rendered {{ 1 // 0 }}, whose
message on CPython 3.11 is 'integer division or modulo by zero' — the
test has never passed anywhere (CI billing-locked since before #136
merged; locally failing since). Switch the fixture to true division
{{ 1 / 0 }}: 'division by zero' on every CPython, so the assertion (the
surfaced detail carries the TYPE only; the full reason rides the cause)
no longer depends on the interpreter's exact spelling. The docstring
records why true division is load-bearing.
This was the only test that will be genuinely red on main the moment
the Actions billing lock clears; with it fixed, main's first real CI
run should be green (the other known failure — the oracle coverage
guard — is an intentional drift refusal that passes at the pinned
catalog commit CI checks out).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fixture fix: the render-detail test asserted
division by zerobut rendered{{ 1 // 0 }}— CPython 3.11 spells thatinteger division or modulo by zero, so the test has never passed anywhere (CI has been billing-locked since before #136 merged). The fixture now uses true division{{ 1 / 0 }}, whose message is stable on every CPython; the assertion's intent (detail carries the exception TYPE only; the full reason rides__cause__) is unchanged and now version-independent.This was the only test that will be genuinely red on main when the billing lock clears — with it fixed, main's first real CI run should be green. Suite: 1032 passed; remaining failure is the oracle coverage guard's intentional drift refusal (local catalog tip ≠ pin; passes at the pinned commit CI uses).