Skip to content

fix(tests): make the render-detail fixture's message interpreter-stable #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omarsy merged 1 commit into from
Oct 22, 2026
Merged

fix(tests): make the render-detail fixture's message interpreter-stable #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/test_compose_render_sandbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,13 @@ def test_the_render_error_detail_is_bounded_and_names_only_the_type(tmp_path,
expression was reading, quoted back; an unbounded length), and the manager
both logs and forwards whatever the greffer returns. Interpolating str(exc)
into the surfaced detail would leak that. Pinned on a failure whose message
is known and distinct from the type: ZeroDivisionError, message "integer
division by zero"."""
is known and distinct from the type: ZeroDivisionError. The fixture uses
TRUE division on purpose: `1 / 0` raises "division by zero" on every
CPython, while `1 // 0`'s message differs by version ("integer division
or modulo by zero" on 3.11) — the assertion must not depend on the
interpreter's exact spelling."""
compose = {"services": {"app": {"image": "nginx:alpine",
"environment": {"X": "{{ 1 // 0 }}"}}}}
"environment": {"X": "{{ 1 / 0 }}"}}}}
with pytest.raises(compose_mod.ConfigRenderError) as exc:
_render(compose, tmp_path, monkeypatch)
detail = str(exc.value)
Expand Down
Loading