fix(session): keep process snapshots monotonic - #42
Merged
Conversation
Keep the assertion tied to the two-second supervisor interval while using the production-like one-second reap deadline from the shared test configuration. This avoids treating a loaded macOS runner's inability to reap within 50 ms as a runtime failure.
guicybercode
marked this pull request as ready for review
September 6, 2026 02:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The post-merge macOS quality job for #40 failed twice in PTY lifecycle cleanup, but in different tests. Local exact repetitions stayed green while parallel suite repetition reproduced StopTimedOut in three cleanup tests.
Root cause
Process snapshots are scanned outside the global cache lock. An older scan could finish after a newer root-proving scan and overwrite the cache. A Session ProcessTree could then consume that older snapshot, permanently prune its root identity, skip SIGKILL delivery, and time out.
Changes
Validation
Follow-up to #40.