Repository navigation
Replace travel_time_filter by isoline_filter - #214
Open
LionelZoubritzky-IGN wants to merge 1 commit into
Open
LionelZoubritzky-IGN wants to merge 1 commit into
LionelZoubritzky-IGN wants to merge 1 commit into
Conversation
…eLayerTool shared navigation logic
LionelZoubritzky-IGN
added this pull request to stack #213
October 6, 2026 09:13
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Incorporate isodistance filtering capability into travel_time_filter by reusing the common GpfIsolineLayer navigation machinery.
Motivation
Test: "What are the stadiums within 1km walk of 73 avenue de Paris, Saint-Mandé?"
It should also make reasoning easier for the LLM, because of the common interface between the filter and the layer tool.
Implementation
I keep the separate upper limit of 120 minutes for the filter, separate from the 600 minutes cap on GpfIsolineLayer, because otherwise the filter can become too big (especially with the
carprofile).This may need to be revisited as part of solving #151 by simplifying the resulting filter geometry rather than limiting in the schema.
Testing
npm run build && npm run verify-> 616+4+35 tests all green.Checklist