fix(search): observe application changes outside search lock - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses second-review finding A: application watcher metadata observation now occurs before taking the search mutex. Only NotFound establishes absence; other metadata failures do not fabricate removals. In-memory comparison remains short, and bounded path collection and burst coalescing are preserved.
Updates the architecture overview for the latest-waiting queue, independent cancellation channel, cooperative request budget, publication lock order, and window-scoped command permissions. Avoids logging observed application paths.
Verification
da0345a:8a9cf0e0-0ed1-422and11e4aaa2-3498-4da. Subagent reviews are not human GitHub approvals.Required checks.c45022e59dc1bc96c6d56c204e62312d967afc48has reviewed treee51f26e6268e7312ef3e972c44b94e3a1cf16f64; per-platform build/test identities match, source remained clean, cleanup completed, and all 100 schema-2 timing samples were retained (25/scenario).82acd528bdf48d4370331c144e0826d51244917a8a814f461c2d721e2a78bab4.cdacbd8b64fc09c90ea201bcce2f74ce5ccd16adf60f53683a8ed2fe4d405995.Native latency impact is not inferred from the latch test. No macOS/Wayland native or physical-paint proof is claimed, and no production release is published.