fix(clipboard): retry revision-safe automatic cleanup - #19
Merged
Merged
Conversation
Owner
Author
|
The first native run (36396119645) passed Linux but failed the new Windows journey while waiting for the pending-cleanup UI warning. Diagnostics are retained: the launcher was hidden, and the previous helper did not establish a zero-format clipboard clear. Commit 696c726 now calls Win32 EmptyClipboard directly, requires a zero-format acknowledgement, retains numeric diagnostics, and explicitly restores native visibility before waiting for the UI. This does not establish which precondition caused the original failure. All durable-state/quiet-retry assertions and timeouts remain unchanged. Full local verification passed (44 checker, 248 Rust, 223 browser); two independent repair reviews and a fresh protected native run are pending. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses second-review finding B without changing the no-queued-manual-deletion policy:
Intents and warnings are session-only: no shutdown drain or restart replay is claimed. Backups can retain deleted text. Linux does not implement the upstream-clear heuristic. These limits and the explicit overflow policy are documented.
Verification
696c726: 44 checker, 248 Rust (7 default ignores), 223 mocked-IPC browser tests, formatting/types/Clippy/build passed. The final helper-only delta also passed focused portable tests and types; real Windows execution passed below.1680b085-cce2-469and5ae15f3f-62cb-404. Two fresh native-harness repair approvals:d20174d3-9d77-458andbf4e039d-eef9-4c9. These are subagent reviews, not human GitHub approvals.36396119645passed Linux but timed out at the new Windows pending-warning check. Diagnostics were retained: the launcher was hidden, and the old helper did not verify that the clipboard had zero formats. No exclusive root-cause claim is made.696c726establishes a real Win32 zero-format clear with a validated numeric acknowledgement and restores native window readiness before observing the visibility-gated UI. Assertions and timeouts are unchanged; no automatic retry masks failed fixture setup. Portable helper regressions verify fail-closed parsing and preserved subprocess failures, not Win32 behavior.36398441413caught a helper error: it emitted zero-format JSON, thenCloseClipboardfailed.4f3ff7ekeeps all ownership-sensitive calls within one synchronous C# method and only emits JSON after successful close. No historical thread-switch cause is claimed. Two further independent approvals:6e51a8de-b7ef-48f,852f3b25-0ae5-45d.36401010317passed using the earlier identified package and new test source (buildMatchesSource:false); it was not used as new-head build proof.56095cec93425b64885e0d1a541c31f6db779bc0, tree05a4534e36d3f3078b1f721bc37e7828cad8d5bd, identical to reviewed head4f3ff7e. Cleanup is complete; 100 schema-2 timing samples/platform retained without discards.c201140d571af3a202af02a6976ccc271e267e914c2472c0cb41bd034c89b379; Linux package:608305a44ded6941161aacfe3ae250c99f0d1348e861f009fe9603a89d4d66a4. Failed evidence remains retained. Branch protection was rechecked unchanged; no bypass.No production release, controlled macOS/Wayland native, physical-paint, or historical installed-version upgrade claim.