ci: the init section talks to its own stack when isolated - #201
Merged
Conversation
The generated config kept init's default target url, so validate in an isolated run health-checked the dev stack instead of the run's container and passed or failed with a stack the run does not own. The default is now asserted and then rewritten to $OS, the edit an operator makes first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The
init/validatesection ofdev/e2e-test.shkeptinit's defaulttarget url, so an isolated run health-checked whatever listens on the default
port instead of its own container. The section now asserts the default was
written and then rewrites it to the run's
$OS, the first edit an operatormakes.
init's default is unchanged.How it was verified
./dev/ci-local.shended with a greenRESULTlineRESULT: green — 19 passed, 2 skippedAlso
./dev/ci-local.sh --isolated --only e2e-postgreswith no shared stackrunning: green, section 19 included.
the test suite itself)
Checklist
Closes #198